feat(cloudserver): turn DeadlineExceeded into appropriate gRPC status #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quoral
force-pushed
the
implement-context-timeout-checking
branch
3 times, most recently
from
4bfec89 to
15007aa
Compare
quoral
changed the title
alethenorio
approved these changes
Nov 15, 2023
quoral
force-pushed
the
implement-context-timeout-checking
branch
from
15007aa to
2d6fc81
Compare
As internal context timeouts can be directly propagated up through the cloudrunner-go middlewares, adding a conversion into a wrapped errorwith a gRPC status code improves the reliability and monitoring of the system by ensuring that the status code becomes DeadlineExceeded rather than Internal.
quoral
force-pushed
the
implement-context-timeout-checking
branch
from
2d6fc81 to
620badb
Compare
alethenorio
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As internal context timeouts can be directly propagated up through the cloudrunner-go middlewares, adding a conversion into a wrapped errorwith a gRPC status code improves the reliability and monitoring of the system by ensuring that the status code becomes DeadlineExceeded rather than Internal.