Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Fix shell script run under Windows OS #1461

Merged
merged 3 commits into from
Mar 21, 2022

Conversation

arittner
Copy link

A small fix up that allows almost all sbt make(-*) commands to run under Windows (except sbt make-deb, as a workaround a dev should use a Linux subsystem). There is also a small refactoring included to call Elm now also via Cmd.run.

I checked in parallel to use JDebPackaging instead of DebianPlugin but I faced a bug in the JDebPackaging (maybe a bug in the plugin or in the config). I postpone this adjustment until I have found a solution for it. Because then the complete build would be possible under Windows.

@arittner
Copy link
Author

Ups...

"Some checks were not successful"

[info] Failed to check the site
[info] Error: Dead link in /home/runner/work/docspell/docspell/website/site/content/docs/install/quickstart.md to https://www.unraid.net/: Server error status code (500 Internal Server Error) received
[error] java.lang.RuntimeException: Unsuccessful return: 1
[error] 	at scala.sys.package$.error(package.scala:30)
[error] 	at docspell.build.Cmd$Result.throwIfNot(Cmd.scala:13)
[error] 	at docspell.build.Cmd$.run(Cmd.scala:22)


Interesting.

@arittner
Copy link
Author

The dead link error is correct. The web page is not available. I get a 500 error with https://www.unraid.net/

But I don't know if this is a permanent error (and it was not visible before my change) or this is a temporary random parallel issue. 😀

Copy link
Owner

@eikek eikek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! For the deb packange, I wouldn't put too much effort in this. It is build by github actions only (most of the time :)) and I think it's totally fair to require a linux system to build these.

Don't worry about the dead links, I might exclude external links from this check - it is a bit annoying :).

@eikek eikek merged commit 5e31e86 into eikek:master Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants