feat(node): Add syncing window for header sync #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fl0rek
force-pushed
the
feat/syncing-range
branch
from
5b658f2
to
e940002
Compare
fl0rek
commented
Jun 27, 2024
fl0rek
force-pushed
the
feat/syncing-range
branch
from
b60493b
to
ea7d372
Compare
zvolin
approved these changes
Jun 27, 2024
oblique
reviewed
Jun 27, 2024
Co-authored-by: Maciej Zwoliński <mac.zwolinski@gmail.com> Signed-off-by: Mikołaj Florkiewicz <mikolaj@florkiewicz.me>
fl0rek
force-pushed
the
feat/syncing-range
branch
from
0e3df13
to
dada61a
Compare
oblique
reviewed
Jul 1, 2024
zvolin
approved these changes
Jul 1, 2024
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When starting a new syncing session, check whether header rigth after that (if present in store) is still withing syncing window. This way we fetch at most one syncing batch (512) of old headers outside of syncing window without complicating headers sessions too much.