Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add #[track_caller] on non-async test utils and spawn utils #305

Merged
merged 3 commits into from
Jun 21, 2024

Conversation

oblique
Copy link
Member

@oblique oblique commented Jun 19, 2024

No description provided.

@oblique oblique requested review from fl0rek and zvolin June 19, 2024 10:32
@oblique
Copy link
Member Author

oblique commented Jun 19, 2024

Closes #288

@fl0rek fl0rek enabled auto-merge (squash) June 19, 2024 10:36
@oblique oblique changed the title feat: Add #[track_caller] on test utils and spawn utils feat: Add #[track_caller] on non-async test utils and spawn utils Jun 21, 2024
@oblique
Copy link
Member Author

oblique commented Jun 21, 2024

So #[track_caller] works only on non-async fns. There is a nightly feature for the async track_caller, but there is no progress on it (rust-lang/rust#110011).

@oblique oblique requested review from fl0rek and zvolin June 21, 2024 07:55
@fl0rek fl0rek merged commit 0f93179 into eigerco:main Jun 21, 2024
6 checks passed
@oblique oblique deleted the feat/track-caller branch June 21, 2024 07:57
@zvolin zvolin mentioned this pull request Jun 19, 2024
@zvolin zvolin mentioned this pull request Jul 5, 2024
@zvolin zvolin mentioned this pull request Jul 25, 2024
@zvolin zvolin mentioned this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants