New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wasm): Run Lumina in a Shared Worker #265

Merged

zvolin merged 40 commits into eigerco:main from fl0rek:feat/wasm-node-in-worker

Jun 25, 2024

Member

fl0rek commented Apr 9, 2024 •

edited

Loading

This PR introduces several features:

either SharedWorker or Worker is spawned for the lumina instance, so that we no longer run in main "GUI" thread.
NodeDriver replaces WasmNode and is responsible for steering actual lumina node running inside a Worker. Multiple tabs from the same context can access the same lumina instance. After spawning the shared worker, NodeDriver establishes a request-response communication channel over JS primitives.
Node inside the SharedWorker has server-like infrastructure. onconnect event means that a new connection happened and we're supposed to use event.port[0] to communicate with a newly connected NodeDriver by responding with results of the command we're sent.
Node inside Worker has simplified architecture, since it doesn't need to handle new tabs connecting, but otherwise works the same

fl0rek added 2 commits

April 5, 2024 23:04

wip

f74b8de


          first pass

cef4c0c

zvolin requested review from aaadamgo, oblique and zvolin

April 9, 2024 10:08

fl0rek added 2 commits

April 10, 2024 22:32


          add type safety

830f8eb


          Type safe finish

ac8c77e

fl0rek force-pushed the feat/wasm-node-in-worker branch from ddb3ea8 to ac8c77e Compare

April 11, 2024 08:10

fl0rek added 3 commits

April 12, 2024 09:18


          more macros less code

556003a


          cleanup

ad9a2f5


          Start squeezing the errors through the channel

46768ed

fl0rek marked this pull request as ready for review

April 15, 2024 07:51

fl0rek added 4 commits

April 16, 2024 08:55


          cleanup


          Merge remote-tracking branch 'eiger/main' into feat/wasm-node-in-worker


          Organise the code, add error passing instead of unwraps

8b44387


          appease clippy

700ddec

fl0rek mentioned this pull request

Network selector eigerco/lumina-front#2

Closed

fl0rek added 6 commits

April 18, 2024 20:18


          Roll back to runtime type checking

eefd831


          cleanup, rw fix

b94c5e0


          code organisation and cleanup

431be7a


          finishing touchees

49a3a28


          pass errors through correctly, fix url blob

58496b0


          to all the clippies I loved

fb8c5d6

oblique reviewed

View reviewed changes

node-wasm/src/node.rs Outdated Show resolved Hide resolved

node-wasm/src/worker/channel.rs Outdated Show resolved Hide resolved

cli/static/worker.js Outdated Show resolved Hide resolved

node-wasm/src/worker.rs Outdated Show resolved Hide resolved

node-wasm/src/node.rs Outdated Show resolved Hide resolved

node-wasm/src/worker/channel.rs Outdated Show resolved Hide resolved

node-wasm/src/worker/channel.rs Outdated Show resolved Hide resolved

node-wasm/src/utils.rs Outdated Show resolved Hide resolved

node-wasm/src/node.rs Outdated Show resolved Hide resolved

node/src/p2p.rs Outdated Show resolved Hide resolved

zvolin reviewed

View reviewed changes

node-wasm/src/utils.rs Outdated Show resolved Hide resolved

zvolin reviewed

View reviewed changes

node-wasm/src/worker.rs Outdated Show resolved Hide resolved

zvolin reviewed

View reviewed changes

node-wasm/src/worker.rs Outdated Show resolved Hide resolved

zvolin reviewed

View reviewed changes

node-wasm/src/worker.rs Outdated Show resolved Hide resolved

zvolin reviewed

View reviewed changes

node-wasm/src/worker.rs Outdated Show resolved Hide resolved

zvolin reviewed

View reviewed changes

node-wasm/src/worker.rs Outdated Show resolved Hide resolved

zvolin force-pushed the feat/wasm-node-in-worker branch from d9b19f6 to 0495d05 Compare

May 10, 2024 13:38

zvolin reviewed

View reviewed changes

node-wasm/src/worker.rs Show resolved Hide resolved

oblique reviewed

View reviewed changes

node-wasm/src/worker/channel.rs Outdated Show resolved Hide resolved

node-wasm/src/worker/channel.rs Show resolved Hide resolved

oblique mentioned this pull request

feat(node): Generate events for data sampling that can be used by front-end #276

Merged

fl0rek force-pushed the feat/wasm-node-in-worker branch from 7bf8ae9 to 7fe0397 Compare

May 16, 2024 11:54


          Add Worker/SharedWorker switch for browser that need it

d3a2c92

fl0rek force-pushed the feat/wasm-node-in-worker branch from 7fe0397 to d3a2c92 Compare

May 16, 2024 11:56


          Merge branch 'main' into feat/wasm-node-in-worker

e2ebffd

zvolin reviewed

View reviewed changes

node-wasm/js/worker.js Outdated Show resolved Hide resolved

node-wasm/src/node.rs Show resolved Hide resolved

fl0rek and others added 5 commits

May 17, 2024 09:24


          Update node-wasm/js/worker.js

0867f4b

Co-authored-by: Maciej Zwoliński <mac.zwolinski@gmail.com>
Signed-off-by: Mikołaj Florkiewicz <mikolaj@florkiewicz.me>


          Merge remote-tracking branch 'origin/main' into feat/wasm-node-in-worker

aee53e4


          rework errors to use new js errors and results

db19449


          Merge remote-tracking branch 'origin/main' into feat/wasm-node-in-worker

17ab76a


          Commit to the bit

0d3d7e5

fl0rek mentioned this pull request

Find a way to reliably detect when Worker dies #307

Open

oblique reviewed

View reviewed changes

node-wasm/Cargo.toml Outdated Show resolved Hide resolved

node-wasm/Cargo.toml Outdated Show resolved Hide resolved

node-wasm/Cargo.toml Outdated Show resolved Hide resolved

node-wasm/Cargo.toml Show resolved Hide resolved

node-wasm/Cargo.toml Outdated Show resolved Hide resolved

node-wasm/src/node.rs Outdated Show resolved Hide resolved

node-wasm/src/worker/channel.rs Outdated Show resolved Hide resolved

node-wasm/src/utils.rs Outdated Show resolved Hide resolved

node-wasm/src/utils.rs Show resolved Hide resolved

node-wasm/src/utils.rs Outdated Show resolved Hide resolved

fl0rek and others added 3 commits

June 22, 2024 13:06


          Apply suggestions from code review

1743bf9

Co-authored-by: Yiannis Marangos <psyberbits@gmail.com>
Signed-off-by: Mikołaj Florkiewicz <mikolaj@florkiewicz.me>


          channel simplification 1/2

614cf9e


          pr review

48670ee

oblique reviewed

View reviewed changes

node-wasm/src/utils.rs Outdated Show resolved Hide resolved


          pr reviews

d93a126

fl0rek force-pushed the feat/wasm-node-in-worker branch from 2a09295 to d93a126 Compare

June 24, 2024 06:40


          final touch

7b4f80b

oblique approved these changes

View reviewed changes

zvolin approved these changes

View reviewed changes

Member

zvolin left a comment

🚀

zvolin merged commit e932d3e into eigerco:main

6 checks passed

zvolin mentioned this pull request

chore: release #293

Closed

zvolin mentioned this pull request

chore: release #321

Closed

zvolin mentioned this pull request

chore: release #346

Closed

zvolin mentioned this pull request

chore: release #364

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet