Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix client sending state mechanism that was blocking the executor #36

Merged
merged 29 commits into from
Apr 8, 2024
Merged

fix: Fix client sending state mechanism that was blocking the executor #36

merged 29 commits into from
Apr 8, 2024

Conversation

oblique
Copy link
Member

@oblique oblique commented Mar 15, 2024

No description provided.

@oblique oblique mentioned this pull request Mar 15, 2024
Closed
@oblique oblique force-pushed the fix/sending-state branch from 1e9b310 to 29d3b07 Compare March 15, 2024 19:09
@zvolin zvolin mentioned this pull request Mar 25, 2024
Closed
@oblique oblique marked this pull request as ready for review March 28, 2024 11:50
@oblique oblique requested review from fl0rek and zvolin March 28, 2024 11:50
zvolin
zvolin reviewed Mar 28, 2024
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
fl0rek
fl0rek approved these changes Mar 29, 2024
View reviewed changes
Copy link
Member

@fl0rek fl0rek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! 🎸

src/client.rs Outdated Show resolved Hide resolved
@oblique oblique requested review from zvolin and fl0rek April 4, 2024 13:21
zvolin
zvolin reviewed Apr 5, 2024
View reviewed changes
src/client.rs Show resolved Hide resolved
zvolin
zvolin reviewed Apr 5, 2024
View reviewed changes
src/client.rs Outdated Show resolved Hide resolved
zvolin
zvolin approved these changes Apr 5, 2024
View reviewed changes
Copy link
Member

@zvolin zvolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one! left some questions

fl0rek
fl0rek reviewed Apr 8, 2024
View reviewed changes
Copy link
Member

@fl0rek fl0rek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, especially with the explanations 🎸

Left few comments, mostly grammar nits, typos, otherwise LGTM

src/client.rs Outdated Show resolved Hide resolved
src/client.rs Outdated Show resolved Hide resolved
src/client.rs Outdated Show resolved Hide resolved
src/client.rs Outdated Show resolved Hide resolved
src/client.rs Outdated Show resolved Hide resolved
src/client.rs Outdated Show resolved Hide resolved
src/client.rs Outdated Show resolved Hide resolved
src/client.rs Outdated Show resolved Hide resolved
src/client.rs Outdated Show resolved Hide resolved
src/client.rs Show resolved Hide resolved
oblique and others added 12 commits April 8, 2024 13:46
@oblique @fl0rek
Update src/client.rs
28eace5 
Co-authored-by: Mikołaj Florkiewicz <mikolaj@florkiewicz.me>
@oblique @fl0rek
Update src/client.rs
aebbe7b 
Co-authored-by: Mikołaj Florkiewicz <mikolaj@florkiewicz.me>
@oblique @fl0rek
Update src/client.rs
dc427e7 
Co-authored-by: Mikołaj Florkiewicz <mikolaj@florkiewicz.me>
@oblique @fl0rek
Update src/client.rs
f23dac7 
Co-authored-by: Mikołaj Florkiewicz <mikolaj@florkiewicz.me>
@oblique @fl0rek
Update src/client.rs
b835547 
Co-authored-by: Mikołaj Florkiewicz <mikolaj@florkiewicz.me>
@oblique @fl0rek
Update src/client.rs
bbf1d63 
Co-authored-by: Mikołaj Florkiewicz <mikolaj@florkiewicz.me>
@oblique @fl0rek
Update src/client.rs
8060e52 
Co-authored-by: Mikołaj Florkiewicz <mikolaj@florkiewicz.me>
@oblique @fl0rek
Update src/client.rs
05fb620 
Co-authored-by: Mikołaj Florkiewicz <mikolaj@florkiewicz.me>
@oblique @fl0rek
Update src/client.rs
cbe6d5a 
Co-authored-by: Mikołaj Florkiewicz <mikolaj@florkiewicz.me>
@oblique @fl0rek
Update src/client.rs
e03ef50 
Co-authored-by: Mikołaj Florkiewicz <mikolaj@florkiewicz.me>
@oblique @fl0rek
Update src/client.rs
8441fbb 
Co-authored-by: Mikołaj Florkiewicz <mikolaj@florkiewicz.me>
@oblique
fmt
b92e525
@fl0rek fl0rek merged commit 1cdfff8 into eigerco:main Apr 8, 2024
6 checks passed
This was referenced Apr 15, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fl0rek fl0rek fl0rek approved these changes

@zvolin zvolin zvolin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oblique @fl0rek @zvolin