CI for fediblockhole #64
Merged
+518
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
offbyone
commented
Sep 29, 2024
•
offbyone
commented
- build and validate the sdist using hynek/build-and-inspect-python-package
- run pytest tests in each supported Python version
- collect and report coverage
- ensure that a developer install works
This was referenced Sep 29, 2024
Closed
offbyone
force-pushed
the
ci-build-and-test
branch
from
d98c7cd
to
901dabf
Compare
|
This has been idle for a bit; is there anything you'd like me to do before you merge it, or should I abandon it? |
jpwarren
requested changes
Nov 1, 2024
There was a problem hiding this comment.
Good PR overall, and agreed that adding CI will help automate stuff.
Main concern is dropping support for Python 3.6. It's not a hard blocker, just want to understand how necessary it is. We'll need to clearly communicate to admins that it's getting dropped, and do that in a specific release. I suggest the 0.5.0 release. If we can keep 3.6 support, that'd be preferable, but we will need to drop old versions eventually.
I appreciate you taking the time to set this up.
I held this out depending on whether you agreed with adding `uv` as a tool; guidance from the tool is to also commit the lock fiels to make sure that development and CI use consistent and predictable versions.
jpwarren
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.