Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove excess selector code #1587

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
7b79806
Removed Selector Code
simonge Aug 20, 2024
2f8fae7
Added functionality to the RangeSplit and ValueSplit functors
simonge Aug 20, 2024
0f2ce1d
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Aug 20, 2024
a601ad4
Changes suggested by sonarcloud
simonge Aug 20, 2024
ccce8f5
Overload the constructor rather than messing around with variants
simonge Aug 20, 2024
c499b4e
Re-add default
simonge Aug 20, 2024
95286e9
More sonarcloud advised changes
simonge Aug 20, 2024
20cb0b4
Remove suggested const flags to see if the CI behaves better
simonge Aug 20, 2024
134a54d
Removed Selector Code
simonge Aug 20, 2024
0e1c3a1
Added functionality to the RangeSplit and ValueSplit functors
simonge Aug 20, 2024
fc9c691
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Aug 20, 2024
5aed707
Changes suggested by sonarcloud
simonge Aug 20, 2024
2c188c2
Overload the constructor rather than messing around with variants
simonge Aug 20, 2024
bbff480
Re-add default
simonge Aug 20, 2024
6b3010e
More sonarcloud advised changes
simonge Aug 20, 2024
9786e24
Remove suggested const flags to see if the CI behaves better
simonge Aug 20, 2024
28e73c0
Merge remote-tracking branch 'origin/main' into Remove-Excess-Selecto…
simonge Aug 28, 2024
320406e
Merge branch 'Remove-Excess-Selector-Code' of github.com:eic/EICrecon…
simonge Aug 28, 2024
5f943e0
Fix indentation
simonge Aug 28, 2024
c336c4f
Created BooleanSplit functor and reverted ValueSplit
simonge Aug 28, 2024
b13bbe8
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Aug 28, 2024
d22b853
Convert BooleanSplit to use float type as the charged field in Recons…
simonge Aug 28, 2024
6b1c511
Merge branch 'Remove-Excess-Selector-Code' of github.com:eic/EICrecon…
simonge Aug 28, 2024
5acacfd
specify float array
simonge Aug 28, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
pre-commit-ci[bot] committed Aug 20, 2024
commit 0f2ce1d263e142d655389d49684ffc893137706c
4 changes: 2 additions & 2 deletions src/algorithms/meta/SubDivideFunctors.h
Original file line number Diff line number Diff line change
@@ -20,7 +20,7 @@ class RangeSplit {
using T = std::decay_t<decltype(arg)>;
if constexpr (std::is_same_v<T, bool>) {
m_inside = std::vector<bool>(ranges.size(), arg);
} else if constexpr (std::is_same_v<T, std::vector<bool>>) {
} else if constexpr (std::is_same_v<T, std::vector<bool>>) {
if (arg.size() != ranges.size()) {
throw std::invalid_argument("Size of inside must match the size of ranges");
} else {
@@ -130,7 +130,7 @@ class ValueSplit {
if(m_ids[i] != values){
ids.push_back(i);
}
}
}
}
return ids;
}