Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rust-lang/rust
switched to shallow clones for submodules and it started causing problems withsubup
. The two I have encountered are:cargo
submodule, the PR description it would create would not include all of the correct commit, but they would be in the actual commitcargo
submodule, it would fail as it couldn't find the revisionAfter much testing, it appears both of these are caused by shallow clones and can be fixed by unshallowing the submodules. One way to do this is to use
git fetch --unshallow
, which is the approach I took in this PR. One thing to note with--unshallow
is it can only be run on shallow clones.