fix signed integer oveflow which is UB and silencing other warnings #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manu-sh
changed the title
Manu-sh
commented
Oct 25, 2021
| @@ -4,3 +4,4 @@ | |||
| test | |||
| *.d | |||
| base45 | |||
| .idea/ | |||
There was a problem hiding this comment.
nothing just prevent to push my ide folder
Manu-sh
commented
Oct 25, 2021
| @@ -47,7 +47,7 @@ int base45_encode(char * dst, size_t *_max_dst_len, const unsigned char * src, s | |||
| size_t out_len = 0, max_dst_len; | |||
| max_dst_len = _max_dst_len ? *_max_dst_len : src_len * 4; | |||
|
|
|||
| for(int i = 0; i < src_len; i+=2) { | |||
| for(unsigned i = 0; i < src_len; i+=2) { | |||
There was a problem hiding this comment.
silencing warnings about different sign
| @@ -101,19 +101,19 @@ int base45_decode(unsigned char * dst, size_t * _max_dst_len, const char * src, | |||
| if (src_len == 0) | |||
| src_len = strlen(src); | |||
|
|
|||
| for(int i = 0; i < src_len; i+=3) { | |||
| for(unsigned i = 0; i < src_len; i+=3) { | |||
There was a problem hiding this comment.
silencing warnings about different sign
|
|
||
| if ((255 == (a = _C2I[src[i]])) || (255 == (b = _C2I[src[i+1]]))) | ||
| if ((255 == (a = _C2I[(unsigned char)src[i]])) || (255 == (b = _C2I[(unsigned char)src[i+1]]))) |
There was a problem hiding this comment.
unsigned integer overflow is well defined, so this cast silence other useless warnings
| @@ -21,7 +21,7 @@ void check(char * in, char * out) { | |||
| assert(0 == bcmp(dec,in,dlen)); | |||
|
|
|||
| printf("base64(\"%s\") -> \"%s\"\n", (char*)dec, enc); | |||
| }; | |||
| } | |||
There was a problem hiding this comment.
C standards doesn't allow ; after function definitions
| @@ -30,4 +30,4 @@ int main(int argc, char **argv) { | |||
| check("COVID-19","-M8*+A%R81A6"); | |||
| check("2021 Digital Green Certificates for travel", | |||
| "NF6OF6P34SED-EDAECS34ZKE1$CO345$CBWER.CGPC7WE.OEX.CBJEKWEKEC: C"); | |||
| }; | |||
| } | |||
There was a problem hiding this comment.
C standards doesn't allow ; after function definitions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As you should know signed integer overflow is UB, apart from that I strongly suggest you enable at least the compiler warnings (
-Walland-Wextraflags), i haven't looked for any other bugs.