WIP Add test for clip rendering.

egramond · Apr 27, 2022 · 9ce9a81 · 9ce9a81
1 parent ede7645
commit 9ce9a81
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 4 deletions.
diff --git a/impeller/aiks/aiks_unittests.cc b/impeller/aiks/aiks_unittests.cc
@@ -97,5 +97,15 @@ TEST_F(AiksTest, CanRenderCurvedStrokes) {
   // ASSERT_TRUE(OpenPlaygroundHere(canvas.EndRecordingAsPicture()));
 }
 
+TEST_F(AiksTest, CanRenderClips) {
+  Canvas canvas;
+  Paint paint;
+  paint.color = Color::Fuchsia();
+  canvas.ClipPath(
+      PathBuilder{}.AddRect(Rect::MakeXYWH(0, 0, 100, 100)).CreatePath());
+  canvas.DrawPath(PathBuilder{}.AddCircle({100, 100}, 50).CreatePath(), paint);
+  ASSERT_TRUE(OpenPlaygroundHere(canvas.EndRecordingAsPicture()));
+}
+
 }  // namespace testing
 }  // namespace impeller
diff --git a/impeller/aiks/canvas.cc b/impeller/aiks/canvas.cc
@@ -77,10 +77,7 @@ void Canvas::SaveLayer(const Paint& paint, std::optional<Rect> bounds) {
 }
 
 void Canvas::ClipPath(Path path) {
-  Entity entity;
-  entity.SetTransformation(GetCurrentTransformation());
-  entity.SetPath(std::move(path));
-  GetCurrentPass().PushEntity(std::move(entity));
+  passes_.push_back({});
 }
 
 void Canvas::DrawShadow(Path path, Color color, Scalar elevation) {}

diff --git a/impeller/renderer/allocator.h b/impeller/renderer/allocator.h
@@ -47,6 +47,9 @@ class Context;
 class DeviceBuffer;
 class Texture;
 
+//------------------------------------------------------------------------------
+/// @brief      An object that allocates device memory.
+///
 class Allocator {
  public:
   virtual ~Allocator();