import issue fix #2000
import issue fix #2000
Conversation
📝 WalkthroughWalkthroughThe pull request introduces modifications to the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range comments (3)
health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/components/BoundaryWithDate.js (3)
Line range hint
9-11: Remove redundant commented code.The line
// const { t } = useTranslation();is redundant as it's already declared above.const { t } = useTranslation(); const tenantId = Digit.ULBService.getCurrentTenantId(); - // const { t } = useTranslation();
Line range hint
31-71: Consider refactoring date validation logic for better maintainability.The date handling logic is repeated across
handleDateChangeandhandleCycleDateChange. Consider extracting the common validation logic into a utility function.+const isValidDate = (date, today) => { + return typeof date !== "undefined" && date > today; +}; const handleDateChange = ({ date, endDate = false, cycleDate = false, cycleIndex }) => { - if (typeof date === "undefined" || date <= today) { + if (!isValidDate(date, today)) { return null; } // ... rest of the function }; const handleCycleDateChange = ({ date, endDate = false, cycleIndex }) => { - if (typeof date === "undefined" || date <= today) { + if (!isValidDate(date, today)) { return null; } // ... rest of the function };
Line range hint
134-146: Improve readability of date validation logic.The validation logic in the FieldV1 components uses complex nested ternary operations and inline date calculations. Consider extracting these into helper functions for better readability and maintainability.
+const getMinStartDate = (index, cycleDates, today, startDate) => { + if (index > 0 && cycleDates?.find((j) => j.cycleIndex == index)?.endDate) { + const prevCycleEndDate = new Date(cycleDates?.find((j) => j.cycleIndex == index)?.endDate); + return new Date(prevCycleEndDate.getTime() + ONE_DAY_IN_MS).toISOString().split("T")[0]; + } + return today >= startDate ? today : startDate; +}; populators={{ validation: { - min: index > 0 && !isNaN(new Date(cycleDates?.find((j) => j.cycleIndex == index)?.endDate)?.getTime()) - ? new Date(new Date(cycleDates?.find((j) => j.cycleIndex == index)?.endDate)?.getTime() + ONE_DAY_IN_MS) - ?.toISOString() - ?.split("T")?.[0] - : today >= startDate - ? today - : startDate, + min: getMinStartDate(index, cycleDates, today, startDate), max: endDate, }, }}
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
📒 Files selected for processing (2)
health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/components/BoundaryWithDate.js(1 hunks)health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/hooks/useProjectSearchWithBoundary.js(0 hunks)
💤 Files with no reviewable changes (1)
- health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/hooks/useProjectSearchWithBoundary.js
🧰 Additional context used
📓 Path-based instructions (1)
health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/components/BoundaryWithDate.js (1)
Pattern **/*.js: check
🔇 Additional comments (1)
health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/components/BoundaryWithDate.js (1)
4-5: LGTM! Import cleanup improves code maintainability.
The removal of unused imports and addition of only necessary components helps reduce bundle size and improves code clarity.
Choose the appropriate template for your PR:
Feature PR
Feature Request
JIRA ID
Module
Description
Related Issues
Bugfix PR
Bugfix Request
JIRA ID
Module
Description
Root Cause
Related Issues
Release PR
Summary by CodeRabbit
BoundaryWithDatecomponent for improved date management and rendering.useProjectSearchWithBoundaryfunction for better performance.BoundaryWithDatecomponent to clean up the codebase.