Citizen sidebar cache

[mithunhegde-egov]

home removed from citizen login screen
hrms boundary dropdown updated

Summary by CodeRabbit

• New Features

  • Added a "HOME" link to the sidebar, enhancing navigation for users based on their role (employee or citizen).
  • Improved sidebar functionality with a new method to close the sidebar and redirect users to the services page.

• Bug Fixes

  • Enhanced validation logic during employee creation, ensuring correct handling of tenant IDs and mandatory fields.

• Chores

  • Removed the "LANGUAGE" menu item and login button for authenticated users to streamline the sidebar experience.

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes involve updates to the StaticCitizenSideBar component, where a new closeSidebar function is introduced to redirect users to the /citizen/all-services path. A "HOME" link is added to the sidebar menu, conditionally rendered based on user type. The sidebar menu configuration also sees the removal of the "HOME" entry. Additionally, modifications to the CreateEmployee component enhance tenant handling and validation during the employee creation process.

Changes

File	Change Summary
micro-ui/web/micro-ui-internals/packages/modules/core/src/components/TopBarSideBar/StaticCitizenSideBar.js	- Added closeSidebar function to redirect to /citizen/all-services. - Introduced "HOME" link in the sidebar, conditionally rendered based on user type. - Adjusted filtering of menu items to remove "LANGUAGE" and "login-btn" for authenticated users. - Minor adjustments to helpline rendering.
micro-ui/web/micro-ui-internals/packages/modules/core/src/config/sidebar-menu.js	- Removed "HOME" link entry from sidebar menu configuration.
micro-ui/web/micro-ui-internals/packages/modules/hrms/src/pages/createEmployee.js	- Added isMultiRootTenant constant to determine tenant type. - Modified handling of Jurisdictions array and refined mandatory field checks during submission. - Enhanced error handling with specific checks and messages.

Possibly related PRs

• side bar #1384: Modifies the sidebar menu configuration by removing the "HOME" link, related to the addition of the "HOME" link in the main PR.
• Side component #1410: Introduces CSS changes that may affect the sidebar layout, relevant to the sidebar's structure changes in the main PR.
• mobile sidebar redirection and cleanup of the sidebar redundant elements #1502: Involves significant changes to the CitizenSideBar, directly relating to the sidebar functionality enhanced in the main PR.
• feedback changes- citizen sidebar login page and loader time increase #1608: Updates the citizen login page sidebar, relevant to the changes in the StaticCitizenSideBar component.

Suggested reviewers

• jagankumar-egov

Poem

🐰 In the sidebar where we play,
A new "HOME" link leads the way.
With a click, we close the door,
To all services, we explore!
Tenant checks, oh what a sight,
Enhancements make our code just right! 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

📥 Commits

Files that changed from the base of the PR and between 5006b5e and 45dad96.

📒 Files selected for processing (3)

• micro-ui/web/micro-ui-internals/packages/modules/core/src/components/TopBarSideBar/SideBar/StaticCitizenSideBar.js (2 hunks)
• micro-ui/web/micro-ui-internals/packages/modules/core/src/config/sidebar-menu.js (0 hunks)
• micro-ui/web/micro-ui-internals/packages/modules/hrms/src/pages/createEmployee.js (3 hunks)

💤 Files with no reviewable changes (1)

• micro-ui/web/micro-ui-internals/packages/modules/core/src/config/sidebar-menu.js

🧰 Additional context used

📓 Path-based instructions (2)

micro-ui/web/micro-ui-internals/packages/modules/core/src/components/TopBarSideBar/SideBar/StaticCitizenSideBar.js (1)

Pattern **/*.js: check

micro-ui/web/micro-ui-internals/packages/modules/hrms/src/pages/createEmployee.js (1)

Pattern **/*.js: check

🪛 Biome

micro-ui/web/micro-ui-internals/packages/modules/hrms/src/pages/createEmployee.js

[error] 150-150: This let declares a variable that is only assigned once.

'selectedCity' is never reassigned.

Safe fix: Use const instead.

(lint/style/useConst)

🔇 Additional comments (5)

micro-ui/web/micro-ui-internals/packages/modules/core/src/components/TopBarSideBar/SideBar/StaticCitizenSideBar.js (2)

117-119: LGTM: New closeSidebar function added.

The closeSidebar function is well-implemented. It correctly uses the history.push method to navigate to the all-services page, and the use of window?.contextPath ensures compatibility with different deployment configurations.

---

Line range hint 1-324: Overall assessment: Changes improve navigation and maintain code quality.

The additions to the StaticCitizenSideBar component enhance the user experience by providing a clear way to return to the home page. The new closeSidebar function and the "HOME" menu item are well-implemented and consistent with the existing code style. These changes align with the PR objectives of updating the citizen sidebar.

micro-ui/web/micro-ui-internals/packages/modules/hrms/src/pages/createEmployee.js (3)

19-19: LGTM!

The introduction of isMultiRootTenant correctly enhances tenant handling based on the multi-root tenant configuration.

---

154-155: ⚠️ Potential issue

Verify if overwriting jurisdiction boundaries is intended

In the mapping of data.Jurisdictions, each jurisdiction's boundary is being overwritten with selectedCity, which is derived from the first jurisdiction's boundary. This means all jurisdictions will have the same boundary. If jurisdictions are supposed to have different boundaries, this could lead to incorrect data.

Please confirm if this behavior is intentional. If not, consider adjusting the code to preserve the original boundaries of each jurisdiction.

---

182-187: ⚠️ Potential issue

Ensure correct assignment of tenantId for roles

The assignment of item["tenantId"] uses ele.boundary when isMultiRootTenant is false. Verify that ele.boundary represents a valid tenantId. Typically, tenantId and boundary may not be interchangeable.

Consider whether ele.tenantId should be used instead:

-    item["tenantId"] = ele.boundary;
+    item["tenantId"] = ele.tenantId;

If ele.boundary is indeed the correct value for tenantId in this context, no action is needed. Otherwise, adjust the assignment to use the appropriate tenant identifier.