Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Dummy Loader and Module Card enhance #1483

Merged
merged 16 commits into from
Oct 9, 2024
Merged

Added Dummy Loader and Module Card enhance #1483

merged 16 commits into from
Oct 9, 2024

Conversation

nabeelmd-eGov
Copy link
Contributor

@nabeelmd-eGov nabeelmd-eGov commented Oct 9, 2024

  • added module card desc
  • added local
  • added
  • css update
  • css citizen fixes
  • css color code fixes. workbench Issue fixes
  • fixes
  • FIXES
  • FIXES
  • add dummy install loader / and module card enhance
  • css upgrad

Summary by CodeRabbit

Release Notes

  • New Features

    • Introduced a loading screen component for the sandbox setup process, enhancing user experience during loading times.
    • Added new CSS styles for loading indicators and installation steps, improving the visual presentation of the sandbox component.
  • Bug Fixes

    • Adjusted navigation logic for authenticated users to direct them to the correct setup path.
  • Chores

    • Updated the stylesheet version for improved styling consistency across the application.

@nabeelmd-eGov nabeelmd-eGov requested a review from a team as a code owner October 9, 2024 10:39
@jagankumar-egov jagankumar-egov merged commit ca944df into develop Oct 9, 2024
2 checks passed
@jagankumar-egov jagankumar-egov deleted the fixes branch October 9, 2024 10:40
Copy link
Contributor

coderabbitai bot commented Oct 9, 2024

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The changes in this pull request introduce enhancements to the user interface of the sandbox component, primarily through new CSS styles and a new loading screen component. A series of CSS classes are added to manage loading animations and installation steps. Additionally, a new route is established in the application to render a loading screen during user setup. The existing components and routing logic are adjusted to accommodate these changes without altering their fundamental behavior.

Changes

File Change Summary
micro-ui/web/micro-ui-internals/packages/css/src/pages/employee/sandbox.scss Added multiple new CSS classes for loading animations and installation steps, including .sandbox-loader, .sandbox-loader-screen, and .sandbox-installation-steps.
micro-ui/web/micro-ui-internals/packages/modules/core/src/App.js Introduced DummyLoaderScreen component and added a new route for user setup path, rendering the loading screen.
micro-ui/web/micro-ui-internals/packages/modules/core/src/components/DummyLoader.js Created DummyLoaderScreen component to manage loading steps with state management and side effects related to the loading process.
micro-ui/web/micro-ui-internals/packages/modules/core/src/pages/employee/Otp/index.js Updated redirectPath in Otp component to direct users to the new setup path instead of the previous URL.
micro-ui/web/micro-ui-internals/packages/modules/core/src/components/RoleBasedEmployeeHome.js Made formatting adjustments for improved code readability without changing functionality.
micro-ui/web/public/index.html Updated stylesheet link for @egovernments/digit-ui-css package from version 1.8.2-beta.38 to 1.8.2-beta.39.

Possibly related PRs

  • css fix  #1399: Modifies the sandbox.scss file, enhancing the user interface and layout, directly related to this PR.
  • Sandbox landing page #1406: Introduces new CSS styles in sandbox.scss, aligning with the focus on enhancing the sandbox component's layout and presentation.
  • sandbox enhancement #1411: Adds new styles and modifies existing ones in sandbox.scss, relevant to the main PR's enhancements.
  • Sandbox UI fixes #1442: Includes modifications to sandbox.scss that enhance styling and layout, directly related to the main PR's focus.
  • fixes #1466: Involves changes to sandbox.scss, focusing on style enhancements relevant to the updates in this PR.
  • breadcrumbs dss & COMMON_MASTER_null showing fix  #1473: Updates to the sandbox.scss file, relevant to the main PR's changes that enhance the sandbox UI.
  • Mp assumptions #1477: Updates the sandbox.scss file, directly related to the main PR's focus on enhancing the sandbox component's layout and presentation.

Suggested reviewers

  • jagankumar-egov

Poem

🐰 In the sandbox where we play,
New styles dance and sway,
A loader spins, steps unfold,
In vibrant hues, our tale is told.
With paths anew, we leap and bound,
In this UI wonder, joy is found! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants