side bar mobileview and sidebar link order fixes

[mithunhegde-egov]

sidebar mobile screen fixes

Summary by CodeRabbit

• New Features

  • Enhanced localization in the CitizenSideBar with icons for language items and improved translation for tenant labels.
  • Updated the EmployeeSideBar to ensure proper sorting of items even when orderNumber is missing.
  • Changed the icon representation for the home link in the sidebar menu.

• Bug Fixes

  • Improved sorting logic in the EmployeeSideBar to handle missing orderNumber values correctly.

[coderabbitai]

📝 Walkthrough

Walkthrough

The pull request introduces updates to the CitizenSideBar and EmployeeSideBar components, enhancing localization and user interface features. Key changes include the addition of an icon property in the hamburgerItems array for CitizenSideBar, improvements to the sorting logic in EmployeeSideBar, and a modification of the icon property in the sidebar menu configuration. These changes aim to improve user experience by refining the display and sorting of items.

Changes

File	Change Summary
.../CitizenSideBar.js	Added icon property for language in hamburgerItems; updated city label to use translation function t(); modified useEffect for tenant items; added icon to transformedLanguageData.
.../EmployeeSideBar.js	Updated sorting logic in sortDataByOrderNumber to assign Infinity to missing orderNumber, ensuring proper sorting. Comments revised for clarity.
.../sidebar-menu.js	Changed icon property for the first menu item from "HomeIcon" to "Home". No other changes made.

Possibly related PRs

• side bar #1384: Changes in EmployeeSideBar.js involve navigation logic that may relate to sidebar functionality.
• side bar with correct order  #1394: Modifications in EmployeeSideBar.js enhance logic and structure, relevant to user roles and navigation.
• Side component #1410: Updates in sidebar-menu.js regarding icon properties relate to UI elements in CitizenSideBar.js.
• Sandbox UI fixes #1442: Modifications in sandbox.scss enhance styling and layout, potentially affecting CitizenSideBar.
• SN 261 #1460: Addition of a new sidebar component directly relates to functionality in CitizenSideBar.js.
• fixes #1466: CSS updates may enhance the visual presentation of CitizenSideBar.
• breadcrumbs dss & COMMON_MASTER_null showing fix  #1473: Changes to breadcrumbs could indirectly relate to sidebar navigation improvements.

Suggested reviewers

• jagankumar-egov
• nabeelmd-eGov

🐰 In the sidebar where we play,
Icons and labels lead the way.
With translations bright and clear,
Navigation brings us cheer!
Sorting logic now refined,
A better path for all to find! 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 2

🧹 Outside diff range comments (1)

micro-ui/web/micro-ui-internals/packages/modules/core/src/components/TopBarSideBar/SideBar/EmployeeSideBar.js (1)

Line range hint 137-151: Improved sorting logic, but consider further enhancements.

The updated sortDataByOrderNumber function now correctly handles missing orderNumber values, which is a good improvement. However, there are a few suggestions to enhance it further:

1. Use Number.POSITIVE_INFINITY instead of Infinity for better readability and consistency with ECMAScript standards.
2. Add a type check for orderNumber to handle potential non-numeric values.

Here's a suggested implementation incorporating these improvements:

const sortDataByOrderNumber = (data) => {
  // Sort the current level of data by orderNumber, handling cases where orderNumber might be missing or invalid
  data.sort((a, b) => {
    const aOrder = typeof a.orderNumber === 'number' ? a.orderNumber : Number.POSITIVE_INFINITY;
    const bOrder = typeof b.orderNumber === 'number' ? b.orderNumber : Number.POSITIVE_INFINITY;
    return aOrder - bOrder;
  });

  // Recursively sort the children if they exist
  data.forEach((item) => {
    if (item.children && item.children.length > 0) {
      sortDataByOrderNumber(item.children);
    }
  });

  return data;
};

This implementation:

• Uses Number.POSITIVE_INFINITY for better standards compliance.
• Adds a type check to ensure orderNumber is treated as a number, preventing potential issues with non-numeric values.

🧰 Tools

🪛 Biome

[error] 139-139: Use Number.Infinity instead of the equivalent global.

ES2015 moved some globals into the Number namespace for consistency.
Safe fix: Use Number.Infinity instead.

(lint/style/useNumberNamespace)

---

[error] 140-140: Use Number.Infinity instead of the equivalent global.

ES2015 moved some globals into the Number namespace for consistency.
Safe fix: Use Number.Infinity instead.

(lint/style/useNumberNamespace)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

📥 Commits

Files that changed from the base of the PR and between 3bb9055 and e12ca47.

📒 Files selected for processing (3)

• micro-ui/web/micro-ui-internals/packages/modules/core/src/components/TopBarSideBar/SideBar/CitizenSideBar.js (2 hunks)
• micro-ui/web/micro-ui-internals/packages/modules/core/src/components/TopBarSideBar/SideBar/EmployeeSideBar.js (1 hunks)
• micro-ui/web/micro-ui-internals/packages/modules/core/src/config/sidebar-menu.js (1 hunks)

🧰 Additional context used

📓 Path-based instructions (3)

micro-ui/web/micro-ui-internals/packages/modules/core/src/components/TopBarSideBar/SideBar/CitizenSideBar.js (1)

Pattern **/*.js: check

micro-ui/web/micro-ui-internals/packages/modules/core/src/components/TopBarSideBar/SideBar/EmployeeSideBar.js (1)

Pattern **/*.js: check

micro-ui/web/micro-ui-internals/packages/modules/core/src/config/sidebar-menu.js (1)

Pattern **/*.js: check

🪛 Biome

micro-ui/web/micro-ui-internals/packages/modules/core/src/components/TopBarSideBar/SideBar/EmployeeSideBar.js

[error] 139-139: Use Number.Infinity instead of the equivalent global.

ES2015 moved some globals into the Number namespace for consistency.
Safe fix: Use Number.Infinity instead.

(lint/style/useNumberNamespace)

---

[error] 140-140: Use Number.Infinity instead of the equivalent global.

ES2015 moved some globals into the Number namespace for consistency.
Safe fix: Use Number.Infinity instead.

(lint/style/useNumberNamespace)

🔇 Additional comments (3)

micro-ui/web/micro-ui-internals/packages/modules/core/src/components/TopBarSideBar/SideBar/CitizenSideBar.js (3)

110-110: LGTM: Improved localization for tenant labels

The change wraps the tenant label with the translation function t(), which enhances the localization capabilities of the component. This is a good practice for ensuring proper translation of UI elements.

---

367-368: LGTM: Consistent icon addition for language item

The addition of the icon: "Language" property to the language item in the hamburgerItems array is consistent with the earlier change in transformedLanguageData. This enhances the visual consistency of the language selection option throughout the sidebar component.

---

Line range hint 1-468: Overall assessment: Improvements align with PR objectives

The changes made to the CitizenSideBar component successfully address the PR objectives of improving the mobile view and enhancing localization. Key improvements include:

1. Better localization for tenant labels
2. Consistent addition of icons for language selection
3. Visual enhancements to the sidebar menu items

These changes contribute to a more user-friendly and visually consistent interface, particularly for mobile users. The code modifications are well-implemented and maintain good coding practices.