Summary screen2 #1433

abishekTa-egov · 2024-09-27T05:36:38Z

Cherry picked from previous summary-screen1, updated css package version and made configurable custom compoent for the tab pages

coderabbitai · 2024-09-27T05:36:43Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (7)

master
develop
hcm-test
mf-build-docker
base-hcm-workbench
microplan
campaign

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

nipunarora-eGov · 2024-09-27T05:47:08Z

...cro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/SummaryScreen.js

+    const { name } = useParams();
+    const tenantId = Digit.ULBService.getCurrentTenantId();
+
+    const [totalFormData, setTotalFormData] = Digit.Hooks.useSessionStorage("MICROPLAN_DATA", {});


@abishekTa-egov you will get this as props

nipunarora-eGov · 2024-09-27T05:47:34Z

...cro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/SummaryScreen.js

+    const data = {
+        cards: [
+            {
+                navigationKey: "card1",


don't name card1, card2... Pls name appropriate to the card

It was what they have also named before

nipunarora-eGov · 2024-09-27T05:49:03Z

...cro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/SummaryScreen.js

+                sections: [
+                    {
+                        type: "DATA",
+                        cardHeader: { value: t("General Estimation"), inlineStyles: { marginTop: 0, fontSize: "1.5rem", color: " #0B4B66" } },


As discussed don't hardcode these items
@abishekTa-egov
it should be dynamic, totalFormData
If not available for now keep a dummy object for this and map over it, don't hardcode according to screen

taking from CustomProps and then putting path

nipunarora-eGov · 2024-09-27T05:49:46Z

...cro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/SummaryScreen.js

+                                props: {
+
+                                    title:"GENERAL_ESTIMATION",
+                                    threeInputArr:[["Number of households per boundary","Population of the boundary","Divided by","Average people HJ/H"],


But this is tab-page na, so we need to send specific and exact info to component

nipunarora-eGov · 2024-09-27T05:50:12Z

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/index.js

@@ -71,6 +72,8 @@ const App = ({ path, stateCode, userType, tenants }) => {
        </React.Fragment>
         <PrivateRoute path={`${path}/setup-microplan`} component={() => <SetupMicroplan />} />
         <PrivateRoute path={`${path}/microplan-search`} component={() => <MicroplanSearch></MicroplanSearch>} /> 
+         <PrivateRoute path={`${path}/summary-screen`} component={() => <SummaryScreen></SummaryScreen>} /> 


Since this is not required now remove it

nipunarora-eGov · 2024-09-27T05:50:55Z

.../micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/ThreeInputComp.js

+import { useTranslation } from "react-i18next";
+import { Card, Header, LabelFieldPair, Button } from "@egovernments/digit-ui-react-components";
+import { Dropdown, FieldV1 } from "@egovernments/digit-ui-components";
+import { TextInput } from "@egovernments/digit-ui-components";


Name this component properly

Like FormulaView or something

nipunarora-eGov · 2024-09-27T05:51:29Z

.../micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/ThreeInputComp.js

+
+            <TextInput
+              type="text"
+              value={"Population of boundary"}


Again here stuff is hardcoded

yeah made the changes

nipunarora-eGov · 2024-09-27T05:51:44Z

...-ui/web/micro-ui-internals/packages/modules/microplan/src/components/HeaderPlusThreeInput.js

+
+
+          return (
+            <ThreeInputComp 


Name component properly

renamed to FormulaSectionComp.js

nipunarora-eGov · 2024-09-27T05:52:20Z

...-ui/web/micro-ui-internals/packages/modules/microplan/src/components/HeaderPlusThreeInput.js

+
+          return (
+            <ThreeInputComp 
+              output={arr[0]} 


just send all this data in one prop and access accordingly in compnent

I think it will be more readable and structured , so we know what we are sending

nipunarora-eGov

Pls make the requested changes

nipunarora-eGov

As discussed , all these points must be fixed in your next pr. Till the time assumptions and formulas are done from @Bhargav-egov side

abishekTa-egov added 2 commits September 27, 2024 10:06

Cherrrypicked from summary-screen1

5915506

Removed console.log made css changes

66ef9a8

nipunarora-eGov reviewed Sep 27, 2024

View reviewed changes

nipunarora-eGov requested changes Sep 27, 2024

View reviewed changes

Merge branch 'console' into summary-screen2

e966adb

nipunarora-eGov approved these changes Sep 27, 2024

View reviewed changes

nipunarora-eGov merged commit 7e0a50b into console Sep 27, 2024
2 checks passed

nipunarora-eGov deleted the summary-screen2 branch September 27, 2024 07:05

nabeelmd-eGov mentioned this pull request Dec 10, 2024

FacilityMapping #2011

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Summary screen2 #1433

Summary screen2 #1433

abishekTa-egov commented Sep 27, 2024

coderabbitai bot commented Sep 27, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

nipunarora-eGov Sep 27, 2024

abishekTa-egov Sep 27, 2024

nipunarora-eGov Sep 27, 2024

abishekTa-egov Sep 27, 2024

nipunarora-eGov Sep 27, 2024

abishekTa-egov Sep 27, 2024

nipunarora-eGov Sep 27, 2024

abishekTa-egov Sep 27, 2024

nipunarora-eGov Sep 27, 2024

nipunarora-eGov Sep 27, 2024

nipunarora-eGov Sep 27, 2024

nipunarora-eGov Sep 27, 2024

abishekTa-egov Sep 27, 2024

nipunarora-eGov Sep 27, 2024

abishekTa-egov Sep 27, 2024

nipunarora-eGov Sep 27, 2024

abishekTa-egov Sep 27, 2024

nipunarora-eGov left a comment

nipunarora-eGov left a comment

Summary screen2 #1433

Summary screen2 #1433

Conversation

abishekTa-egov commented Sep 27, 2024

coderabbitai bot commented Sep 27, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nipunarora-eGov left a comment

Choose a reason for hiding this comment

nipunarora-eGov left a comment

Choose a reason for hiding this comment

CodeRabbit Configuration File (`.coderabbit.yaml`)