-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix test on windows #18
Conversation
@dead-horse, thanks for your PR! By analyzing the history of the files in this pull request, we identified @popomore, @atian25 and @fengmk2 to be potential reviewers. |
看看日志,schedule 也要 close? |
@popomore app.close 之后 schedule 就会停了,agent 进程都退出了 |
Codecov Report
@@ Coverage Diff @@
## master #18 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 3 3
Lines 104 104
=====================================
Hits 104 104 Continue to review full report at Codecov.
|
看看这个日志,里面 logger 被关闭了还在打印,说明 interval 没关 https://travis-ci.org/eggjs/egg-schedule/jobs/225680044 |
app.close 之后,agent 没退出? |
我后面再看看吧,现在看来就是影响自己的测试。而且这个是 cluster 模式启动的 |
我看到有一个 stop schedule 的用例,确保了 app.close 之后没有执行 schedule 的,日志的报错感觉不是 schedule 打出来的。 |
好的 |
Checklist
npm test
passesAffected core subsystem(s)
Description of change