Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix test on windows #18

Merged
merged 1 commit into from
Apr 26, 2017
Merged

test: fix test on windows #18

merged 1 commit into from
Apr 26, 2017

Conversation

dead-horse
Copy link
Member

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@mention-bot
Copy link

@dead-horse, thanks for your PR! By analyzing the history of the files in this pull request, we identified @popomore, @atian25 and @fengmk2 to be potential reviewers.

@popomore
Copy link
Member

看看日志,schedule 也要 close?

@dead-horse
Copy link
Member Author

@popomore app.close 之后 schedule 就会停了,agent 进程都退出了

@codecov
Copy link

codecov bot commented Apr 26, 2017

Codecov Report

Merging #18 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #18   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      3           
  Lines         104    104           
=====================================
  Hits          104    104

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 329b7f7...ae8187d. Read the comment docs.

@popomore
Copy link
Member

看看这个日志,里面 logger 被关闭了还在打印,说明 interval 没关 https://travis-ci.org/eggjs/egg-schedule/jobs/225680044

@dead-horse
Copy link
Member Author

app.close 之后,agent 没退出?

@popomore
Copy link
Member

@dead-horse
Copy link
Member Author

我后面再看看吧,现在看来就是影响自己的测试。而且这个是 cluster 模式启动的

@dead-horse
Copy link
Member Author

我看到有一个 stop schedule 的用例,确保了 app.close 之后没有执行 schedule 的,日志的报错感觉不是 schedule 打出来的。

@popomore
Copy link
Member

好的

@popomore popomore merged commit 1976951 into master Apr 26, 2017
@popomore popomore deleted the fix-windows-test branch April 26, 2017 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants