Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename class name to HourRotator #29

Merged
merged 1 commit into from
Feb 2, 2025
Merged

Conversation

kaidiren
Copy link
Contributor

@kaidiren kaidiren commented Feb 23, 2021

this file is Hour Rotator not day Rotator

[skip ci]

this file is Hour Rotator not day Rotator
@codecov
Copy link

codecov bot commented Feb 23, 2021

Codecov Report

Merging #29 (1899199) into master (46b6876) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #29   +/-   ##
=======================================
  Coverage   96.19%   96.19%           
=======================================
  Files          14       14           
  Lines         210      210           
=======================================
  Hits          202      202           
  Misses          8        8           
Impacted Files Coverage Δ
app/lib/hour_rotator.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46b6876...230e099. Read the comment docs.

@elvinn
Copy link

elvinn commented Mar 2, 2021

👍

@fengmk2 fengmk2 changed the title rename class name to HourRotator fix: rename class name to HourRotator Feb 2, 2025
@fengmk2 fengmk2 merged commit 3863a39 into eggjs:master Feb 2, 2025
fengmk2 pushed a commit that referenced this pull request Feb 3, 2025
[skip ci]

## [4.0.0](v3.2.0...v4.0.0) (2025-02-03)

### ⚠ BREAKING CHANGES

* drop Node.js < 18.19.0 support

part of eggjs/egg#3644

eggjs/egg#5257

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Package renamed to **@eggjs/logrotator** with updated installation
instructions and documentation.
- Enhanced log rotation configuration for improved file retention and
compression.

- **Refactor**
  - Migrated the codebase to ES Modules with full TypeScript support.
- Streamlined asynchronous handling in both core functionality and
tests.

- **Chores**
- Updated CI workflows to support modern Node.js versions (18, 20, 22).
  - Refined linting and version control ignore configurations.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

### Features

* add disableRotateByDay configuration(default:false) ([#28](#28)) ([73690a8](73690a8))
* support cjs and esm both by tshy ([#33](#33)) ([fa42511](fa42511))
* support gzip compress on rotate file ([#30](#30)) ([059d1c8](059d1c8))

### Bug Fixes

* rename class name to HourRotator ([#29](#29)) ([3863a39](3863a39))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants