Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Set Keyword On Failure #67

Open
damies13 opened this issue Feb 27, 2022 · 3 comments
Open

Feature Request: Set Keyword On Failure #67

damies13 opened this issue Feb 27, 2022 · 3 comments

Comments

@damies13
Copy link

A keyword from selenium library that I found quite useful was Register Keyword To Run On Failure.

This feature request is for the equivalent keyword in IHL. I am aware you can set the keyword_on_failure at import, but having the keyword allows you to temporarily change the keyword_on_failure and then change it back.

Background:
Here is a link to my forum post where I explained the situation where this functionality is useful.

I will provide a PR for this feature request.
damies13 added a commit to damies13/robotframework-imagehorizonlibrary that referenced this issue Feb 27, 2022
@damies13
Issue eficode#67 Feature Request: Set Keyword On Failure
e5a9d5a 
resolves Issue eficode#67 Feature Request: new keyword Set Keyword On Failure
@damies13 damies13 mentioned this issue Feb 27, 2022
Open
@simonmeggle
Copy link

Is there a reason not to implement this keyword? It would be extremely helpful and the change is indeed minimal.

@damies13
Copy link
Author

Thanks Simon for the appreciation, I tried contributing things I thought would make the library better, and some fixes for existing issues, now it's up to the project owner.

@simonmeggle
Copy link

Sorry, my comment was misleading. It was addressed to the project owner, @Tattoo :-)

noubar added a commit to noubar/Robotframework-ImageLibrary that referenced this issue Oct 17, 2024
@noubar
Squashed commit of the following:
cf80050 
commit e5a9d5a
Author: Dave Amies <damies13@gmail.com>
Date:   Sun Feb 27 14:38:46 2022 +1000

    Issue eficode#67 Feature Request: Set Keyword On Failure

    resolves Issue eficode#67 Feature Request: new keyword Set Keyword On Failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@simonmeggle @damies13