-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When running ImageHorizonLibrary.Take A Screenshot keyword, path to the image should relative and not absolute #28
Comments
I looked at the code for ImageHorizonLibrary.Take A Screenshot today, I think I can provide a fix for this. |
damies13
added a commit
to damies13/robotframework-imagehorizonlibrary
that referenced
this issue
Feb 25, 2022
damies13
added a commit
to damies13/robotframework-imagehorizonlibrary
that referenced
this issue
Feb 25, 2022
After testing needed a minor change, not sure why raw string didn't work, but escaped string does.
For anyone else having this issue, I have a workaround I use for now until the PR is added to a release. I use sed to update the output.xml and then use rebot to regenerate the html reports like this:
|
noubar
added a commit
to noubar/Robotframework-ImageLibrary
that referenced
this issue
Oct 17, 2024
commit 85cd76a Author: Dave Amies <damies13@gmail.com> Date: Fri Feb 25 22:24:00 2022 +1000 Fix for Issue eficode#28 relative path for screenshots 2 After testing needed a minor change, not sure why raw string didn't work, but escaped string does. commit e6cf36f Author: Dave Amies <damies13@gmail.com> Date: Fri Feb 25 22:02:19 2022 +1000 Fix for Issue eficode#28 relative path for screenshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When I run my tests in CI, I do not want to store the the results in the job which did the actually running. I move the result to different places and even to outside of the CI. But because the
ImageHorizonLibrary.Take A Screenshot
keyword saves the paths to image as absolute paths, the images are not anymore shown when I move thelog.html
to a different folder structure.Example when I save the Robot Framework results in
/path/to/workspace/output/
folder, then withImageHorizonLibrary.Take A Screenshot
keyword the DOM is like this:But it should be like this:
Example in Selenium2Library the same logic is done in here: https://github.com/robotframework/Selenium2Library/blob/master/src/Selenium2Library/keywords/screenshot.py#L115
The text was updated successfully, but these errors were encountered: