Fix Renamer to conform to contract given in docs #332
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still missing but in comments: We do not copy annotations in the context. |
I think the comment can be deleted, we don't need to :) |
b-studios
reviewed
Dec 4, 2023
| // maps symbols bound in the current scope to their renamed variants. | ||
| private var bound: Map[Id, Id] = Map.empty | ||
| private var bound: List[Map[Id, Id]] = List.empty |
There was a problem hiding this comment.
Do we really need this list of maps?
There was a problem hiding this comment.
Need is a bit strong. We can get away without, but then we can't have unbind and have to do something like:
val tBinding = rewrite(binding)
withBinding(x) { Let(rewrite(x), tBinding, rewrite(body)) }
for non-recursive bindings.
Which is fine, too, admittedly.
There was a problem hiding this comment.
Oh, and we could - of course - replace this with a proper Environment type with a lookup.
|
Thanks, cherry picked. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the problem noted in #316 (comment) ,
and should make the output Barendregt unless the generated names (prefix + number / original name + number) are already in use.
@b-studios .