Direct-style (DS) JS Backend

effekt/jvm/src/test/scala/effekt/core/RenamerTests.scala

@@ -128,6 +128,7 @@ class RenamerTests extends CoreTests {
   test("pseudo recursive"){
     val input =
       """ module main
+        |
         | def bar = { () => return 1 }
         | def main = { () =>
         |   def foo = { () => (bar : () => Unit @ {})() }
@@ -138,6 +139,7 @@ class RenamerTests extends CoreTests {
 
     val expected =
       """ module main
+        |
         | def bar = { () => return 1 }
         | def main = { () =>
         |   def renamed1 = { () => (bar : () => Unit @ {})() }
@@ -148,4 +150,28 @@ class RenamerTests extends CoreTests {
 
     assertRenamedTo(input, expected)
   }
+  // TODO this needs to be fixed
+  //  test("shadowing let bindings"){
+  //    val input =
+  //      """ module main
+  //        |
+  //        | def main = { () =>
+  //        |   let x = 1
+  //        |   let x = 2
+  //        |   return x:Int
+  //        | }
+  //        |""".stripMargin
+  //
+  //    val expected =
+  //      """ module main
+  //        |
+  //        | def main = { () =>
+  //        |   let renamed1 = 1
+  //        |   let renamed2 = 2
+  //        |   return renamed2:Int
+  //        | }
+  //        |""".stripMargin
+  //
+  //    assertRenamedTo(input, expected)
+  //  }
 }

effekt/shared/src/main/scala/effekt/core/Renamer.scala

@@ -54,9 +54,8 @@ class Renamer(names: Names = Names(Map.empty), prefix: String = "") extends core
           // can be recursive
           withBinding(d.id) { go(rest, defs :+ rewrite(d)) }
         case (d : core.Definition.Let) :: rest =>
-          // non-recursive
-          val renamed = rewrite(d)
-          withBinding(d.id) { go(rest, defs :+ renamed) }
+          // TODO let bindings are non-recursive (check that this holds!)
+          withBinding(d.id) { go(rest, defs :+ rewrite(d)) }
         case Nil => core.Scope(defs, rewrite(body))
       }