Remove redundant sample in once
#306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
However, user without TS won't know that returned event is not callable. I believe, we should preserve current behavior for such a case. |
zerobias
approved these changes
Nov 28, 2023
zerobias
added a commit
that referenced
this pull request
Nov 28, 2023
* Use effector 23 release candidate * Remove forward calls * Remove guard usage * greedy: true -> batch: false * remove fork(domain) usage * Remove onlyChanges usage * Use skipVoid: false * use the same TS version, which is used for effector * Comply with TS deprecations and cut unrelevant lib check * Make empty operator work with full-void stores * Use UnitTargetable * Add skipVoid to maps and combines (#302) * Add skipVoid * Use skipVoid false * Use latest rc * Update tests to reflect fixed bug * Remove test for derived event call - it is not supported anymore * Update `and` tests * Update `or` tests * Remove controversial type tests Strict check was expected for a valid case with partial match * Remove type tests for domain or scope in source * Update combine-events type tests * Fix build * Test types against dist * Fix condition types * Fix `{}` in `every` and `some` tests * Fix `name` support in debounce * Fix `spread` types * Fix double debounce trigger (#303) Co-authored-by: Victor Didenko <victord@setplex.com> * Skip failing cases * Add effector 23 support (#304) * Update effector version * Set range of supported effector versions * Ensure that `and` and `or` will updated with scope * Set effector version strictly to 23 (#305) * fix(once): remove redundant sample as of effector v23 (#306) * Fix ci issues (#307) * Update cra integration * Fix lockfile for node 16/18 ci * Use non-strict peer deps in cra integration * Update pnpm * Update lockfile * Update cra lockfile * Update custom integration * Reorder imports --------- Co-authored-by: Dmitry <ribkatt@gmail.com> Co-authored-by: Victor <yumaa.verdin@gmail.com> Co-authored-by: Victor Didenko <victord@setplex.com> Co-authored-by: Mikhail Kireev <29187880+kireevmp@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
effector@23calling a derivedUnitis an error, so asamplethat guarded that behavior is no longer required.