👩🚒 Add bids provider #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
b-tarczynski
commented
Apr 16, 2024
•
b-tarczynski
commented
- To see the specific tasks where the Asana app for GitHub is being used, see below:
- https://app.asana.com/0/0/1207087538287484
❌ Deploy Preview for devcon-raffle failed.
|
# Conflicts: # packages/frontend/src/blockchain/auctionAddresses.ts # packages/frontend/src/pages/_app.tsx # packages/frontend/src/pages/index.tsx # packages/frontend/src/providers/wagmi.tsx
p-sad
reviewed
Apr 16, 2024
Comment on lines
71
to
77
| if (a.amount === b.amount) { | ||
| return 0 | ||
| } | ||
| if (a.amount > b.amount) { | ||
| return -1 | ||
| } | ||
| return 1 |
There was a problem hiding this comment.
Could be Number(b.amount - a.amount) I believe
There was a problem hiding this comment.
We could cover it with tests to make sure if the logic's right too
p-sad
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.