DC7 #1
Merged
DC7 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msieczko
requested changes
Mar 21, 2024
Comment on lines
+38
to
+46
| function setRequiredScore(uint256 newRequiredScore) external onlyOwner { | ||
| emit RequiredScoreUpdated(requiredScore, newRequiredScore); | ||
| requiredScore = newRequiredScore; | ||
| } | ||
|
|
||
| function setAttestor(address newAttestor) external onlyOwner { | ||
| emit AttestorUpdated(attestor, newAttestor); | ||
| attestor = newAttestor; | ||
| } |
There was a problem hiding this comment.
It should probably not be possible to adjust those parameters after the auction-raffle has started.
There was a problem hiding this comment.
IMO it doesn't make a difference since the attestation is centralised/trusted anyway. I included it in case the attestor key gets leaked or something.
| @@ -99,13 +82,18 @@ contract AuctionRaffle is Ownable, Config, BidModel, StateModel { | |||
| * @notice Places a new bid or bumps an existing bid. | |||
| * @dev Assigns a unique bidderID to the sender address. | |||
| */ | |||
| function bid() external payable onlyExternalTransactions onlyInState(State.BIDDING_OPEN) { | |||
| function bid( | |||
There was a problem hiding this comment.
Can we extract a method for bumping bids to avoid having to pass score and proof again?
There was a problem hiding this comment.
Good point, this would be annoying. I separated them out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.