fix(io): fix crash when EDITOR is a full command #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when using a command with options as EDITOR e.g. `emacsclient -nw`, the `editor` command will crash the program: ``` FileNotFoundError: [Errno 2] No such file or directory: 'emacsclient -nw' ``` using `shell=True` in `subprocess` and formatting a command string from our parameters fixes this
efJerryYang
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when using a command with options as EDITOR e.g.
emacsclient -nw, theeditorcommand will crash the program:using
shell=Trueinsubprocessand formatting a command string from our parameters fixes this