Have 'Segment.chunks' yield smaller 'Segment's #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bessman
force-pushed
the
yield_segment
branch
from
de01272
to
b725bf8
Compare
bessman
force-pushed
the
yield_segment
branch
from
b725bf8
to
f892e8b
Compare
|
Tests are passing. I reverted the changes to Should |
|
I'm working on updating outdated docstrings referring to |
bessman
changed the title
|
One subtle change that comes with this is that |
|
Will think about that tomorrow. |
|
I think it's fine. |
eerimoq
reviewed
Sep 19, 2023
|
Went ahead and added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion in #35.
Three tests are failing so it wasn't quite as straight-forward as I'd hoped. I'll try to get them passing.