Fix test config for Windows environments #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Match backslash in Jest config transform paths - Deal with git's core.autocrlf true - Ensure that errors in yaml-test-suite are caused within tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discovered in #306, the tests don't pass on Windows. This adds
windows-latest(andmacos-latestbecause why not) environment to the GitHub Actions Node.js test workflow, and fixes the issues that then arise.It would appear that setting
autocrlf falseis required by the yaml-test-suite tests, as otherwise something there is causing a busy loop that eventually results in aAllocation failed - JavaScript heap out of memorycrash.