Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expand customization options of titleIcons #28

Merged
merged 2 commits into from
Sep 23, 2021

Conversation

ionlizarazu
Copy link
Contributor

  • More options to customize the titleIcons.
  • Rename the icons keys making them more generic
  • Modified the View.jsx to make customization visible

Current configuration:

titleIcons: {
    right: rightSVG,
    down: downSVG,
},

The configuration I prupose is:

titleIcons: {
    closed: { leftPosition: rightSVG, rightPosition: leftSVG },
    opened: { leftPosition: downSVG, rightPosition: downSVG },
},

In this way, we can independently configure the icons when the accordion is opened and closed even when it is on the right or left.

@avoinea
Copy link
Member

avoinea commented Sep 23, 2021

broken

It doesn't look right to me. The arrow in this case should be pointing to the title

Copy link
Member

@avoinea avoinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure it works as before with the default values.

@avoinea
Copy link
Member

avoinea commented Sep 23, 2021

accordion.mp4

@ionlizarazu
Copy link
Contributor Author

ionlizarazu commented Sep 23, 2021

you are right @avoinea , i got confused with right/down names and "opened" and "closed" icons were backwards

@avoinea avoinea merged commit d57c444 into develop Sep 23, 2021
@avoinea avoinea deleted the expand-titleIcon-customization branch September 23, 2021 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants