Visual improvements #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiberiuichim
approved these changes
Sep 6, 2021
avoinea
reviewed
Sep 6, 2021
| @@ -158,7 +161,7 @@ class EditBlockWrapper extends React.Component { | |||
| this.setState({ addNewBlockOpened: false }); | |||
| }} | |||
| currentBlock={block} | |||
| allowedBlocks={allowedBlocks} | |||
| allowedBlocks={allowedBlocks || allowedBlocksFromConfig} | |||
avoinea
approved these changes
Sep 6, 2021
It shouldn't be required, it's used only in Edit mode to visually annotate the accordion section:
💯 |
nileshgulia1
added a commit
that referenced
this pull request
Sep 6, 2021
Release - Visual improvements (#18)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made the panel widget appear as much as possible like the
object_listwidget. Since this widget (panel widget) is quite different (saves an object that has the blocks/blocks_layout nested from first level) I just revamped its look and feel. I used the title as item title in the widget too, addressed some CSS issues.Also as bonus: addressed some CSS issues in rendering and added the ability to pass an
allowedBlockslist from the block config itself.@avoinea What's the title for? I can see it's required, but not used in rendering at all. I can see it's uses, but does it pays off to be required?
Also, I guess next thing is to make it schemaExtender aware. What do you think?