feat: display upgrade panel when audit trial is expired #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rijuma
reviewed
Dec 17, 2024
| @@ -119,7 +119,7 @@ exports[`<TrialDisclosure /> When trial upgrade being shown should match snapsho | |||
| </small> | |||
| </div> | |||
| <a | |||
| class="trial-upgrade mt-3 btn btn-primary btn-block" | |||
| class="trial-upgrade mt-3 btn btn-brand btn-block" | |||
ilee2u
approved these changes
Dec 17, 2024
rijuma
reviewed
Dec 17, 2024
| auditTrialDaysRemaining = Math.ceil((auditTrialExpirationDate - Date.now()) / millisecondsInOneDay); | ||
|
|
||
| auditTrialExpired = auditTrialDaysRemaining < 0; | ||
| } | ||
|
|
||
| const isFBE = !!accessExpiration && !!datesBannerInfo?.contentTypeGatingEnabled; |
There was a problem hiding this comment.
Note: If you want to make sure you are returning a boolean on an expression like this, you can just do:
const isFBE = Boolean(accessExpiration && datesBannerInfo?.contentTypeGatingEnabled);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COSMO-573
When a learner is eligible for upgrade, and their audit trial is expired, an upgrade panel should be shown with a button that takes a learner to the purchase page. Different value props will be shown on the upgrade panel depending on whether or not the course has FBE enabled. The definition for whether or not FBE is enabled has been duplicated from
frontend-plugin-advertisements(see https://github.com/edx/frontend-plugin-advertisements/blob/7eac0c8caf701c17a2aba1f1dbb5c942aea8c290/src/upgrade-modal/DefaultUpgradeModal.jsx#L71).Upgrade panel with FBE:
Upgrade without FBE:
