Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: convert totalRegistrationTime to snake case #133

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

ahtesham-quraish
Copy link
Contributor

@ahtesham-quraish ahtesham-quraish commented Aug 21, 2024

Description

  • Convert totalRegistrationTime to snake case

JIRA

VAN-1816

How Has This Been Tested?

  • Tested locally

Here is the backend PR openedx/edx-platform#35333

Copy link
Contributor

@syedsajjadkazmii syedsajjadkazmii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not reviewing it but wanted to point this little improvement

Comment on lines 286 to 287
payload = snakeCaseObject(payload);
payload.totalRegistrationTime = totalRegistrationTime;
payload.total_registration_time = totalRegistrationTime;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

payload.totalRegistrationTime = totalRegistrationTime;
payload = snakeCaseObject(payload);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahtesham-quraish please take a look at this

Copy link
Contributor

@abdullahwaheed abdullahwaheed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please link backend PR here as well

Comment on lines 286 to 287
payload = snakeCaseObject(payload);
payload.totalRegistrationTime = totalRegistrationTime;
payload.total_registration_time = totalRegistrationTime;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahtesham-quraish please take a look at this

Description:
Convert totalRegistrationTime to snake case
VAN-1816
@ahtesham-quraish ahtesham-quraish merged commit 2338762 into master Aug 29, 2024
5 checks passed
@ahtesham-quraish ahtesham-quraish deleted the ahtesham/van-1816 branch August 29, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants