-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: convert totalRegistrationTime to snake case #133
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not reviewing it but wanted to point this little improvement
payload = snakeCaseObject(payload); | ||
payload.totalRegistrationTime = totalRegistrationTime; | ||
payload.total_registration_time = totalRegistrationTime; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
payload.totalRegistrationTime = totalRegistrationTime;
payload = snakeCaseObject(payload);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ahtesham-quraish please take a look at this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please link backend PR here as well
payload = snakeCaseObject(payload); | ||
payload.totalRegistrationTime = totalRegistrationTime; | ||
payload.total_registration_time = totalRegistrationTime; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ahtesham-quraish please take a look at this
e79f1c5
to
2f61f7a
Compare
Description: Convert totalRegistrationTime to snake case VAN-1816
2f61f7a
to
eb6946c
Compare
Description
JIRA
VAN-1816
How Has This Been Tested?
Here is the backend PR openedx/edx-platform#35333