test: Add Node 20 to CI matrix #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: change attempt id to exam id for launch url
…board into bilalqamar95/node20-upgrade-1
Open
huniafatima-arbi
approved these changes
Sep 16, 2024
Zacharis278
approved these changes
Oct 9, 2024
|
@Zacharis278 Can you please help merge this? It's blocked due to idled This issue is because the CI workflow was updated to include a test matrix for Node versions 18 and 20. Since the test job is marked as a required check, it expects a single status to be reported. With the matrix setup, tests are now running separately for both Node versions, causing the status check to get stuck on idle. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As a first step in the upgrade to Node 20, add it to the CI matrix as a non-blocking test.
See the tracking issue for further information.