Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: node v18 & react v17 upgrade, switched @edx/paragon & @edx/frontend-build to openedx namespace #29

Merged
merged 11 commits into from
May 31, 2024

Conversation

BilalQamar95
Copy link
Contributor

@BilalQamar95 BilalQamar95 commented May 27, 2024

Description

  • Node v18 upgrade, updated .nvmrc and workflow
  • Added workflow to check lockfile version
  • React v17 upgrade
  • Updated @edx/paragon & @edx/frontend-build to openedx namespace
  • Major version upgrades for react-intl and frontend-build along with respective packages

@BilalQamar95 BilalQamar95 self-assigned this May 27, 2024
@BilalQamar95 BilalQamar95 changed the title Bilalqamar95/node react upgrade feat: node v18 & react v17 upgrade, switched @edx/paragon & @edx/frontend-build to openedx namespace May 27, 2024
Copy link
Member

@rijuma rijuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BilalQamar95 BilalQamar95 merged commit 25eb21c into edx:main May 31, 2024
5 checks passed
"@testing-library/jest-dom": "^5.16.5",
"@testing-library/react": "^12.1.5",
"@testing-library/user-event": "14.4.3",
"axios": "^1.4.0",
"axios-mock-adapter": "^1.21.4",
"glob": "7.2.3",
"husky": "7.0.4",
"jest": "29.5.0"
"jest": "29.7.0",
"webpack-dev-server": "5.0.4"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BilalQamar95

I'm way late here but do you have any knowledge about why this change was needed? I thought this was previously installed with frontend-build and frontend-build could find and run it's own version. This is causing problems locally because it doesn't match the same version frontend build expects (v4). I can manually update this to v4 but that doesn't fix the issue of why we'd have to manage this manually in here.

I can't remove it because something in this PR causes the original version of webpack installed by frontend-build not to be found anymore.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Zacharis278 Thank you for looping me in on this, this change was needed since frontend-build couldn't find and run it's own version. I have since traced and resolved the issue, fix PR #39. I have also added you as a reviewer for the PR, kindly review and merge it, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants