Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KBK-1] aka ACADEMIC-16455: user role in feedback #64

Merged
merged 1 commit into from
Oct 10, 2023
Merged

[KBK-1] aka ACADEMIC-16455: user role in feedback #64

merged 1 commit into from
Oct 10, 2023

Conversation

aethant
Copy link
Contributor

@aethant aethant commented Oct 4, 2023 •
edited
Loading

Merge checklist:
Check off if complete or not applicable:

  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Fixup commits are squashed away
  • Unit tests added/updated
  • Manual testing instructions provided
  • Noted any: Concerns, dependencies, migration issues, deadlines, tickets

@aethant aethant force-pushed the ACADEMIC-16455_UserRoleInFeedback branch 2 times, most recently from f7b1816 to 8622d9e Compare October 5, 2023 18:11
@aethant aethant marked this pull request as ready for review October 5, 2023 18:14
@aethant aethant requested review from ashultz0 and rijuma October 5, 2023 18:14
ashultz0
ashultz0 reviewed Oct 5, 2023
View reviewed changes
ai_aside/constants.py Outdated Show resolved Hide resolved
@ashultz0
Copy link
Contributor

ashultz0 commented Oct 5, 2023

this needs an update in the CHANGELOG and to try this out we need to make a new version which is here https://github.com/edx/ai-aside/blob/main/ai_aside/__init__.py - this would be a 3.6 because it's not a breaking change but it is New Stuff, and that will go automatically to stage (version 3.x.x) once we cut the version but not to production (version 3.5.x)

@aethant aethant requested a review from ashultz0 October 5, 2023 19:04
ashultz0
ashultz0 approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@ashultz0 ashultz0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the individual diffs are going to be very useful to future readers so before merge please collapse them together, but good to go.

@aethant aethant force-pushed the ACADEMIC-16455_UserRoleInFeedback branch from a43df67 to f688669 Compare October 6, 2023 14:33
schenedx
schenedx approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@schenedx schenedx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have objections to merge. I do have feedback

ai_aside/block.py Outdated Show resolved Hide resolved
ai_aside/block.py Outdated Show resolved Hide resolved
tests/test_block.py Show resolved Hide resolved
@aethant aethant force-pushed the ACADEMIC-16455_UserRoleInFeedback branch from e410c88 to d6d6a95 Compare October 10, 2023 12:46
@aethant aethant merged commit 3090ad1 into main Oct 10, 2023
4 checks passed
@aethant aethant deleted the ACADEMIC-16455_UserRoleInFeedback branch October 10, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schenedx schenedx schenedx approved these changes

@ashultz0 ashultz0 ashultz0 approved these changes

@rijuma rijuma Awaiting requested review from rijuma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aethant @ashultz0 @schenedx