feat: add log line to positive case #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it's too chatty to add a log every time we might trigger this aside because that is all blocks, but a log line when we intend to is useful for debugging and success measurement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
thought of this when I was working out how we should alert - I don't think we actually need this for alerting but it is useful for debugging
sample line
2023-07-20 13:21:59,530 INFO 118 [ai_aside.block] [user 3] [ip 172.19.0.1] block.py:214 - Summary hook injecting into block-v1:edX+DemoX+Demo_Course+type@vertical+block@vertical_2dbb0072785eMerge checklist:
Check off if complete or not applicable: