Two small tweaks I found essential #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…de block but triggering inline code tags if below a code block! Changed path for GraphViz on windows to use Program Files (x86) as a more modern default
|
Your change "$result .= SmartyPants(Markdown($md));" is already in the latest version. Your other change with a different path (Program Files (x86)): it would be better if it was applied dynamically, at runtime, so users with and without the "(86)" part can use the code. |
|
Hi edwinm, the call is made twice - the current version has it correct in one of these (around line 110 I think) but the other earlier call still is the wrong way round. |
edwinm
added a commit
that referenced
this pull request
Jan 9, 2013
Two small tweaks I found essential
|
You're right. Thanks for the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue with two back ticks triggering curly quotes if above a code block but triggering inline code tags if below a code block
Changed path for GraphViz on windows to use Program Files (x86) as a more modern default