Fix "No such file or directory" warning in LocalCache::invalidate()

If cache file doesn't exist, we shouldn't try to unlink() it.
edwardspec · Jan 1, 2025 · 24114e6 · 24114e6
1 parent 0d145b0
commit 24114e6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/ChangeLog b/ChangeLog
@@ -5,6 +5,9 @@ List of changes between releases of Extension:AWS.
 Minor features:
 * Added "transcoded" zone to $wgAWSRepoZones.
 
+Warnings fixed:
+* Fixed harmless PHP warning in LocalCache::invalidate().
+
 == AWS 0.13.1 ==
 
 * Added support for MediaWiki 1.43.

diff --git a/includes/AmazonS3LocalCache.php b/includes/AmazonS3LocalCache.php
@@ -138,7 +138,7 @@ public static function postDownloadLogic( &$file ) {
 	public static function invalidate( $virtualPath ) {
 		$localPath = self::findLocalPath( $virtualPath );
 
-		if ( $localPath ) {
+		if ( $localPath && file_exists( $localPath ) ) {
 			// TODO: graceful "mark as expired, delete later".
 			// TODO: delete on all webservers (not just this one).
 			$file = new TempFSFile( $localPath );