Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/unime rich credentials #161

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Feature/unime rich credentials #161

merged 2 commits into from
Dec 10, 2024

Conversation

berkes
Copy link
Contributor

@berkes berkes commented Dec 9, 2024

This fixes the unime import button in the POC.

  • The structure of the credential was wrong. identity should be an array and identity[].type a string.
  • The code flow of issuing was wrong: we called sphereon backend outside of the sphereon/unime type conditional.

berkes added 2 commits December 9, 2024 16:50
@berkes
fix: Issue the unime credential and offer in two calls
32dfb44
@berkes
fix: Align the identity attribute with the spec.
7779d0f 
Identity is a list. We use a list of one for now.
Identity.type is not a list, but a string.
@berkes berkes requested a review from Iso5786 December 9, 2024 15:56
@berkes berkes self-assigned this Dec 9, 2024
@Iso5786 Iso5786 merged commit f267f97 into edubadges:develop Dec 10, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Iso5786 Iso5786 Iso5786 approved these changes

Assignees

@berkes berkes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@berkes @Iso5786