Merge test fixes into master #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix v1 webhooks and all unit and acceptance tests.
Co-Authored-By: Eduardo Bouças <mail@eduardoboucas.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My development speed on this project has slowed up a bit while I finish up my final semester in uni so in the meantime I think it would be wise to merge all the test case fixes from before into master. This will allow builds on master to pass (currently they fail and that fact is displayed in a README badge). A few users seem to have successfully deployed the dev branch per discussion on #318 and no major issues have been reported so I feel comfortable with this merge.