Address cppcheck suppressions in lmdb

eduar-hte · Apr 28, 2024 · 68f704f · 68f704f
1 parent 147a62e
commit 68f704f
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 5 deletions.
diff --git a/src/collection/backend/lmdb.cc b/src/collection/backend/lmdb.cc
@@ -659,7 +659,7 @@ MDB_dbi* MDBEnvProvider::GetDBI() {
     return &m_dbi;
 }
 
-bool MDBEnvProvider::isValid() {
+bool MDBEnvProvider::isValid() const {
     return valid;
 }
 

diff --git a/src/collection/backend/lmdb.h b/src/collection/backend/lmdb.h
@@ -83,7 +83,7 @@ class MDBEnvProvider {
     }
     MDB_env* GetEnv();
     MDB_dbi* GetDBI();
-    bool isValid();
+    bool isValid() const;
 
     ~MDBEnvProvider();
  private:

diff --git a/test/cppcheck_suppressions.txt b/test/cppcheck_suppressions.txt
@@ -56,9 +56,6 @@ unreadVariable:src/rule_with_operator.cc:219
 uninitvar:src/operators/verify_cpf.cc:77
 uninitvar:src/operators/verify_svnr.cc:67
 
-functionConst:src/collection/backend/lmdb.h:86
-unusedLabel:src/collection/backend/lmdb.cc:297
-
 variableScope:src/operators/rx.cc
 variableScope:src/operators/rx_global.cc