Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Redwood #53

Closed
wants to merge 2 commits into from
Closed

Upgrade to Redwood #53

wants to merge 2 commits into from

Conversation

MoisesGSalas
Copy link
Member

@MoisesGSalas MoisesGSalas commented May 7, 2024

Description

WIP

Initial redwood support

@MoisesGSalas MoisesGSalas changed the title chore: initial redwood support Upgrade to Redwood May 10, 2024
@DawoudSheraz
Copy link

@MoisesGSalas Hi, the PR branch name is incorrect, it is currentlyredwoood, it should be redwood.

@DawoudSheraz
Copy link

When we attempted this branch in sandbox (https://github.com/overhangio/openedx-release-demo/actions/runs/9077645999/job/24943000965), it failed with the following error:

2 [internal] load metadata for docker.io/library/ubuntu:22.04
#2 ...

#3 [internal] load metadata for docker.io/overhangio/openedx:18.0.0-indigo
#3 ERROR: docker.io/overhangio/openedx:18.0.0-indigo: not found

#2 [internal] load metadata for docker.io/library/ubuntu:22.04
#2 CANCELED
------
 > [internal] load metadata for docker.io/overhangio/openedx:18.0.0-indigo:
------
Dockerfile:54
--------------------
  52 |     RUN mkdir -p common/lib/
  53 |     
  54 | >>> COPY --from=docker.io/overhangio/openedx:18.0.0-indigo /openedx/edx-platform/requirements/edx-sandbox/releases/redwood.txt redwood.txt
  55 |     RUN pip3 install -r redwood.txt
  56 |     
--------------------
ERROR: failed to solve: docker.io/overhangio/openedx:18.0.0-indigo: failed to resolve source metadata for docker.io/overhangio/openedx:18.0.0-indigo: docker.io/overhangio/openedx:18.0.0-indigo: not found

We have tutor-indigo enabled on the sandbox, not sure if that is impacting this.

@MoisesGSalas
Copy link
Member Author

@DawoudSheraz, I don't think it's related to tutor-indigo. If I were to take a wild guess it seems like base openedx image isn't tagged before the codejail image is built. I didn't test with tutor images build all, but rather building the openedx image first and then the codejail image.

I will test to see if I can replicate the error, in the meantime I guess you can add a step to the action that builds the openedx image first and then runs tutor images build all

@DawoudSheraz
Copy link

@DawoudSheraz, I don't think it's related to tutor-indigo. If I were to take a wild guess it seems like base openedx image isn't tagged before the codejail image is built. I didn't test with tutor images build all, but rather building the openedx image first and then the codejail image.

I will test to see if I can replicate the error, in the meantime I guess you can add a step to the action that builds the openedx image first and then runs tutor images build all

Actually, Open edX image is building first in the sequence. I can add the explicit step but I am not sure if that would work. You can see the build logs on https://github.com/overhangio/openedx-release-demo/actions/runs/9077645999/job/24943000965.

@MoisesGSalas
Copy link
Member Author

@DawoudSheraz, I pushed a small workaround to avoid the error when the base image isn't tagged. I will look for a longer term solution.

I pushed the commit to both this mistiped branch redwoood to the new branch redwood that is in #54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants