Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace distro by tutor-contrib-picasso plugin #8

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

mariajgrimaldi
Copy link
Contributor

@mariajgrimaldi mariajgrimaldi commented Sep 2, 2024

Description

This PR replaces the use of the distro plugin with the tutor-contrib-picasso plugin according to this discussion: https://3.basecamp.com/3966315/buckets/12732851/messages. This PR was made based on the changes from: https://github.com/eduNEXT/dedalo-scripts/pull/4

@mariajgrimaldi mariajgrimaldi marked this pull request as ready for review September 12, 2024 14:13
@mariajgrimaldi mariajgrimaldi requested a review from a team September 12, 2024 14:13
Copy link
Contributor

@MaferMazu MaferMazu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. My only comment is to tag the tutor-contrib-picasso to only use releases/tags and not the main version.


pip install git+https://github.com/eduNEXT/tutor-contrib-edunext-distro@$distro_version
tutor plugins enable distro
pip install git+https://github.com/eduNEXT/tutor-contrib-picasso
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pip install git+https://github.com/eduNEXT/tutor-contrib-picasso
pip install git+https://github.com/eduNEXT/tutor-contrib-picasso@v0.1.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mariajgrimaldi mariajgrimaldi changed the base branch from MJG/picasso-action to main September 13, 2024 10:13
@mariajgrimaldi mariajgrimaldi changed the base branch from main to MJG/picasso-action September 13, 2024 10:17
@mariajgrimaldi mariajgrimaldi force-pushed the MJG/use-tutor-contrib-picasso branch from bee6bd0 to e60a9a3 Compare September 13, 2024 10:19
@mariajgrimaldi mariajgrimaldi changed the base branch from MJG/picasso-action to main September 13, 2024 10:20
@mariajgrimaldi mariajgrimaldi force-pushed the MJG/use-tutor-contrib-picasso branch from e60a9a3 to 0be7a79 Compare September 13, 2024 10:22
@mariajgrimaldi mariajgrimaldi merged commit b44aba3 into main Sep 13, 2024
@mariajgrimaldi mariajgrimaldi deleted the MJG/use-tutor-contrib-picasso branch September 18, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants