test: add integration tests for the grade api AP-1406
#302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jignaciopm
changed the title
AP-1406
mariajgrimaldi
requested changes
Nov 7, 2024
jignaciopm
commented
Nov 7, 2024
mariajgrimaldi
requested changes
Nov 11, 2024
There was a problem hiding this comment.
Thank you, @jignaciopm! I've added some additional comments for you to review. Please let me know once you do :)
|
@jignaciopm integration tests are failing. Have you checked why we are getting this error? https://github.com/eduNEXT/eox-core/actions/runs/11840999793/job/32996180959?pr=302#step:2:5674 Also, we need to rebase with master to get the latest changes here |
jignaciopm
force-pushed
the
jipm/AP-1406
branch
from
c300b4b to
b2086c7
Compare
magajh
requested changes
Nov 25, 2024
mariajgrimaldi
approved these changes
Nov 26, 2024
magajh
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
@jignaciopm I'd like to merge this PR first #308, so we can make sure all the integration tests here are passing except for the 'nightly' version
jignaciopm
force-pushed
the
jipm/AP-1406
branch
4 times, most recently
from
df9026a to
ca0f710
Compare
… in the documentation
jignaciopm
force-pushed
the
jipm/AP-1406
branch
from
ca0f710 to
0f5bfcb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds integration tests for the Grade API and remove old module test integrations. These tests are executed in the job of Tutor Integration Tests
Testing instructions
Check the jobs of Tutor Integration Tests in the PR.
Jira Issue
Checklist for Merge