-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add users api docs #290
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @luisfelipec95!
@luisfelipec95 can we rebase this with master to fix the integration tests please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @luisfelipec95!
@luisfelipec95, Could we rebase with master dropping the additional commits? |
55f6a0b
to
5aa677a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@luisfelipec95, I read the documentation and I think it is very good. However, I would modify the structure a bit to make it more orderly, something like this:
Users API Documentation
-
Endpoints
- GET (Get User)
- POST (Create User)
- PATCH (Update User)
-
Extra Profile Fields
The User API supports the use of extra and custom registration fields for...
- Adding a Custom Field
extended_profile_fields
REGISTRATION_EXTRA_FIELDS
EDNX_CUSTOM_REGISTRATION_FIELDS
EOX_CORE_USER_UPDATE_SAFE_FIELDS
(used only in the PATCH requests)
- Types of Custom Fields
- Text
- Select
- Checkbox
- TextArea
- Field Visibility Options
- Required
- Optional
- Hidden
- Optional-Exposed
- Adding a Custom Field
For my part, I have no further comments. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @luisfelipec95!
Co-authored-by: Bryann Valderrama <64033729+BryanttV@users.noreply.github.com>
Co-authored-by: Bryann Valderrama <64033729+BryanttV@users.noreply.github.com>
Co-authored-by: Bryann Valderrama <64033729+BryanttV@users.noreply.github.com>
Co-authored-by: Bryann Valderrama <64033729+BryanttV@users.noreply.github.com>
Co-authored-by: Bryann Valderrama <64033729+BryanttV@users.noreply.github.com>
Co-authored-by: Bryann Valderrama <64033729+BryanttV@users.noreply.github.com>
Co-authored-by: Bryann Valderrama <64033729+BryanttV@users.noreply.github.com>
Co-authored-by: Bryann Valderrama <64033729+BryanttV@users.noreply.github.com>
Co-authored-by: Bryann Valderrama <64033729+BryanttV@users.noreply.github.com>
Co-authored-by: Bryann Valderrama <64033729+BryanttV@users.noreply.github.com>
Co-authored-by: Bryann Valderrama <64033729+BryanttV@users.noreply.github.com>
Co-authored-by: Bryann Valderrama <64033729+BryanttV@users.noreply.github.com>
Co-authored-by: Bryann Valderrama <64033729+BryanttV@users.noreply.github.com>
Co-authored-by: Bryann Valderrama <64033729+BryanttV@users.noreply.github.com>
25cdc39
to
67e7e52
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
This PR adds the user API documentation
Additional information
https://edunext.atlassian.net/browse/AP-1439