Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add users api docs #290

Merged
merged 24 commits into from
Oct 29, 2024
Merged

docs: add users api docs #290

merged 24 commits into from
Oct 29, 2024

Conversation

luisfelipec95
Copy link
Contributor

@luisfelipec95 luisfelipec95 commented Oct 10, 2024

Description

This PR adds the user API documentation

Additional information

https://edunext.atlassian.net/browse/AP-1439

@luisfelipec95 luisfelipec95 requested a review from a team as a code owner October 10, 2024 22:50
@luisfelipec95 luisfelipec95 marked this pull request as draft October 10, 2024 22:50
@luisfelipec95 luisfelipec95 marked this pull request as ready for review October 11, 2024 22:59
Copy link
Contributor

@BryanttV BryanttV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @luisfelipec95!

docs/how_to/users_api.rst Outdated Show resolved Hide resolved
docs/how_to/users_api.rst Outdated Show resolved Hide resolved
docs/how_to/users_api.rst Outdated Show resolved Hide resolved
docs/how_to/users_api.rst Outdated Show resolved Hide resolved
docs/how_to/users_api.rst Outdated Show resolved Hide resolved
docs/how_to/users_api.rst Outdated Show resolved Hide resolved
@magajh
Copy link
Contributor

magajh commented Oct 17, 2024

@luisfelipec95 can we rebase this with master to fix the integration tests please?

Copy link
Contributor

@magajh magajh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @luisfelipec95!

docs/how_to/users_api.rst Outdated Show resolved Hide resolved
docs/how_to/users_api.rst Outdated Show resolved Hide resolved
docs/how_to/users_api.rst Outdated Show resolved Hide resolved
docs/how_to/users_api.rst Outdated Show resolved Hide resolved
docs/how_to/users_api.rst Outdated Show resolved Hide resolved
docs/how_to/users_api.rst Show resolved Hide resolved
docs/how_to/users_api.rst Outdated Show resolved Hide resolved
docs/how_to/users_api.rst Show resolved Hide resolved
@BryanttV
Copy link
Contributor

@luisfelipec95, Could we rebase with master dropping the additional commits?

docs/how_to/users_api.rst Show resolved Hide resolved
docs/how_to/users_api.rst Outdated Show resolved Hide resolved
docs/how_to/users_api.rst Outdated Show resolved Hide resolved
docs/how_to/users_api.rst Outdated Show resolved Hide resolved
docs/how_to/users_api.rst Outdated Show resolved Hide resolved
docs/how_to/users_api.rst Outdated Show resolved Hide resolved
docs/how_to/users_api.rst Outdated Show resolved Hide resolved
docs/how_to/users_api.rst Show resolved Hide resolved
docs/how_to/users_api.rst Outdated Show resolved Hide resolved
docs/how_to/users_api.rst Outdated Show resolved Hide resolved
@luisfelipec95 luisfelipec95 force-pushed the lfc/update-doc-api-users branch from 55f6a0b to 5aa677a Compare October 22, 2024 18:21
@github-actions github-actions bot added size/m and removed size/xl labels Oct 22, 2024
docs/how_to/users_api.rst Outdated Show resolved Hide resolved
docs/how_to/users_api.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@BryanttV BryanttV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luisfelipec95, I read the documentation and I think it is very good. However, I would modify the structure a bit to make it more orderly, something like this:

Users API Documentation

  • Endpoints

    • GET (Get User)
    • POST (Create User)
    • PATCH (Update User)
  • Extra Profile Fields

    The User API supports the use of extra and custom registration fields for...

    • Adding a Custom Field
      • extended_profile_fields
      • REGISTRATION_EXTRA_FIELDS
      • EDNX_CUSTOM_REGISTRATION_FIELDS
      • EOX_CORE_USER_UPDATE_SAFE_FIELDS (used only in the PATCH requests)
    • Types of Custom Fields
      • Text
      • Select
      • Checkbox
      • TextArea
    • Field Visibility Options
      • Required
      • Optional
      • Hidden
      • Optional-Exposed

For my part, I have no further comments. Thanks!

docs/how_to/users_api.rst Outdated Show resolved Hide resolved
docs/how_to/users_api.rst Outdated Show resolved Hide resolved
docs/how_to/users_api.rst Outdated Show resolved Hide resolved
docs/how_to/users_api.rst Show resolved Hide resolved
docs/how_to/users_api.rst Outdated Show resolved Hide resolved
BryanttV
BryanttV previously approved these changes Oct 28, 2024
Copy link
Contributor

@BryanttV BryanttV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @luisfelipec95!

docs/how_to/users_api.rst Outdated Show resolved Hide resolved
luisfelipec95 and others added 22 commits October 28, 2024 10:16
Co-authored-by: Bryann Valderrama <64033729+BryanttV@users.noreply.github.com>
Co-authored-by: Bryann Valderrama <64033729+BryanttV@users.noreply.github.com>
Co-authored-by: Bryann Valderrama <64033729+BryanttV@users.noreply.github.com>
Co-authored-by: Bryann Valderrama <64033729+BryanttV@users.noreply.github.com>
Co-authored-by: Bryann Valderrama <64033729+BryanttV@users.noreply.github.com>
Co-authored-by: Bryann Valderrama <64033729+BryanttV@users.noreply.github.com>
Co-authored-by: Bryann Valderrama <64033729+BryanttV@users.noreply.github.com>
Co-authored-by: Bryann Valderrama <64033729+BryanttV@users.noreply.github.com>
Co-authored-by: Bryann Valderrama <64033729+BryanttV@users.noreply.github.com>
Co-authored-by: Bryann Valderrama <64033729+BryanttV@users.noreply.github.com>
Co-authored-by: Bryann Valderrama <64033729+BryanttV@users.noreply.github.com>
Co-authored-by: Bryann Valderrama <64033729+BryanttV@users.noreply.github.com>
Co-authored-by: Bryann Valderrama <64033729+BryanttV@users.noreply.github.com>
Co-authored-by: Bryann Valderrama <64033729+BryanttV@users.noreply.github.com>
@luisfelipec95 luisfelipec95 force-pushed the lfc/update-doc-api-users branch from 25cdc39 to 67e7e52 Compare October 28, 2024 15:17
Copy link
Contributor

@magajh magajh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@luisfelipec95 luisfelipec95 merged commit 3109281 into master Oct 29, 2024
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants