Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: add palm support DS-703 #254

Merged
merged 12 commits into from
Nov 30, 2023
Merged

perf: add palm support DS-703 #254

merged 12 commits into from
Nov 30, 2023

Conversation

MaferMazu
Copy link
Contributor

@MaferMazu MaferMazu commented Nov 17, 2023

Description

This migration PR does the following:

Testing instructions

  1. Install the plugin in a palm environment.
  2. Follow the test case document (File: https://docs.google.com/document/d/1gaQyHBGDDkvy_NsFw07MRV6uI2R49CeWCDHzTVi_TiI/edit?usp=sharing)
  3. Review this checklist:
  • Installation.
  • Backends.
  • Github actions.
  • Test cases.
  • Improvements.
  • Requirements.
  • Documentation.

Additional information

Related PR: #257

@MaferMazu MaferMazu force-pushed the mfmz/palm-support branch 5 times, most recently from 9cc5cda to 4fe1d00 Compare November 22, 2023 01:12
@MaferMazu MaferMazu changed the title Mfmz/palm support perf: add palm support Nov 22, 2023
@MaferMazu MaferMazu force-pushed the mfmz/palm-support branch 2 times, most recently from 924de29 to a9ccb3d Compare November 22, 2023 02:53
@MaferMazu
Copy link
Contributor Author

The tests were passed. It starts to fail when I update the readme for the length of the PR. For now, I will put the labeler fail in false, but if you think it is too long, I will split the readme update in another PR.

@MaferMazu MaferMazu marked this pull request as ready for review November 22, 2023 03:05
@MaferMazu MaferMazu requested a review from a team November 22, 2023 03:05
@MaferMazu MaferMazu changed the title perf: add palm support perf: add palm support DS-703 Nov 22, 2023
@MaferMazu MaferMazu force-pushed the mfmz/palm-support branch 3 times, most recently from 0822b7d to 1b18997 Compare November 23, 2023 23:17
@MaferMazu
Copy link
Contributor Author

I would like to merge #257, #258, and #256 before merging this.

bra-i-am
bra-i-am previously approved these changes Nov 24, 2023
Copy link
Contributor

@bra-i-am bra-i-am left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is working as expected!

I left a little comment in the test cases doc, but nothing else.

dcoa
dcoa previously approved these changes Nov 28, 2023
@MaferMazu MaferMazu dismissed stale reviews from dcoa and bra-i-am via bb78b9d November 28, 2023 17:12
@MaferMazu
Copy link
Contributor Author

@dcoa @bra-i-am, can you help me with a review again?

@dcoa
Copy link
Contributor

dcoa commented Nov 29, 2023

@MaferMazu, Is it possible to rebase the branch to update it, instead of generating a merge commit?

@MaferMazu
Copy link
Contributor Author

@dcoa ready!

@bra-i-am bra-i-am self-requested a review November 30, 2023 15:25
@MaferMazu MaferMazu merged commit 732c1bf into master Nov 30, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants