-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable custom_reg_form capability #253
Conversation
6dd83eb
to
3ac4bef
Compare
Enable the custom_reg_form. The field could be used using the `REGISTRATION_EXTENSION_FORM` dict setting. https://github.com/openedx/edx-platform/blob/master/openedx/core/djangoapps/user_authn/views/register.py#L205
3ac4bef
to
930d5a1
Compare
@johanv26 this didn't work for me, is something missing ? 2023-11-17.18-28-15.mp4 |
@andrey-canon do you have this setting? |
@andrey-canon I think I had to specify in the PR description how to enable the custom_reg_form. >>> settings.REGISTRATION_EXTENSION_FORM
'custom_reg_form.forms.ExtraInfoForm' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@johanv26 could you open the pr against the master branch ? If you haven't done yet btw I had to change the setting |
Ok I think that would work by default, but thank you for the explanation. PR opened: |
Enable the custom_reg_form. The field could be used using the `REGISTRATION_EXTENSION_FORM` dict setting. https://github.com/openedx/edx-platform/blob/master/openedx/core/djangoapps/user_authn/views/register.py#L205 refs: #253
Enable the custom_reg_form. The field could be used using the `REGISTRATION_EXTENSION_FORM` dict setting https://github.com/openedx/edx-platform/blob/master/openedx/core/djangoapps/user_authn/views/register.py#L205 refs: #253
The field could be used using the `REGISTRATION_EXTENSION_FORM` setting. https://github.com/openedx/edx-platform/blob/master/openedx/core/djangoapps/user_authn/views/register.py#L205 This is a feature of upstream openedx, the platform has that capability of registration extension models and maybe for people like opencraft would like. refs: #253
The capability could be used enabled using the `REGISTRATION_EXTENSION_FORM` setting. https://github.com/openedx/edx-platform/blob/master/openedx/core/djangoapps/user_authn/views/register.py#L205 This is a feature of upstream openedx, the platform has that capability of registration extension models and maybe for people like opencraft would like. refs: #253
The capability could be used enabled using the `REGISTRATION_EXTENSION_FORM` setting. This is a feature of upstream openedx, the platform has that capability of registration extension models and maybe for people like opencraft would like. refs: #253
The capability could be used enabled using the `REGISTRATION_EXTENSION_FORM` setting. This is a feature of upstream openedx, the platform has that capability of registration extension models and maybe for people like opencraft would like. refs: #253
Description
Enable the custom_reg_form.
The field could be used using the
EDNX_CUSTOM_REGISTRATION_FIELDS
setting.Based in this edx-platform logic
Testing instructions
Add this setting with some fields related to an extended custom reg form.
Post a user with the extra_field.
Check the user was created and in the extended custom reg model.
If you add the field is also stored in the model and meta.
Additional information
This dont affect anything if you dont have defined the setting
REGISTRATION_EXTENSION_FORM
.setting management
Other wise that definition would give the validation rules of that form to the endpoint.
So with with a falsy value, the form works with previous behaviour.
Checklist for Merge