-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added logs to errors imports #259
Conversation
Thanks for this @BetoFandino. |
Hi @MaferMazu, super thank you very much but then I ask you two little things: |
You already have this PR @BetoFandino; we can continue the process of adding the try-except to sentry imports in your PR, and in the palm support PR, handle the |
Ok @MaferMazu, then I will make the pertinent changes in this PR. Thank you very much!!! 😃 |
@BetoFandino, do you still want to merge this? |
@MaferMazu if possible yes please |
@BetoFandino, can you fix the issues, please? |
hi! I hope you're well. @BetoFandino, just a friendly reminder about this PR so we can continue the merging process, thank you c: |
Thanks for updating this, @BetoFandino. I only have a question: Why do we need the file coursekey_h_v1? In my understanding, that file is to support the Open edX Release Hawthorn, and right now, we have a coursekey_m_v1 that supports Maple and all the next releases. The rest looks good to me. When we figure out the Hawthorn backend, we will be good to merge. |
Hi @MaferMazu , yes you are right coursekey_h_v1 is no longer needed, I removed it and updated the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
ab47a0f
to
99db7d1
Compare
Logs in errors imports
Description
This change is due to the difficulty in tracking errors in some imports. They will help to locate faster any errors or warnings that may occur that may hinder testing and debugging.
Useful information to include:
Checklist for Merge