Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: sumac release support #43

Merged
merged 7 commits into from
Dec 12, 2024
Merged

perf: sumac release support #43

merged 7 commits into from
Dec 12, 2024

Conversation

luisfelipec95
Copy link
Contributor

Description

This PR aims to support the new Sumac Release

Testing instructions

1, Create a Sumac environment using Tutor or TVM.
2. Install eox-audit-model using this branch you can follow the official tutor documentation.
3. Follow the test cases file.

Additional information

https://github.com/eduNEXT/eox-release/issues/183

@magajh
Copy link
Contributor

magajh commented Dec 10, 2024

@luisfelipec95 As part of the process for supporting the new release, please review (and merge if necessary) the PRs opened by Dependabot: #42
We need to keep the workflow dependencies as up-to-date as possible

@magajh
Copy link
Contributor

magajh commented Dec 10, 2024

@luisfelipec95 I think we can mark this PR as ready for review and leave the update it here once you've run all test cases in the remote environment

@luisfelipec95 luisfelipec95 marked this pull request as ready for review December 10, 2024 04:23
@luisfelipec95 luisfelipec95 requested a review from a team as a code owner December 10, 2024 04:23
Copy link
Contributor

@magajh magajh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luisfelipec95 we need to update the CHANGELOG

@luisfelipec95
Copy link
Contributor Author

The test cases were executed locally, pending in stage

@luisfelipec95
Copy link
Contributor Author

The test cases have already been tested in the remote sumac environment

Copy link
Contributor

@magajh magajh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@magajh
Copy link
Contributor

magajh commented Dec 11, 2024

@luisfelipec95 is this branch updated with the latest changes in master?

Copy link

@Asespinel Asespinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some testing in my local and everything is working

@luisfelipec95 luisfelipec95 merged commit c53de8d into master Dec 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants