Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve readme #31

Merged
merged 4 commits into from
Jul 15, 2024
Merged

docs: improve readme #31

merged 4 commits into from
Jul 15, 2024

Conversation

dcoa
Copy link
Contributor

@dcoa dcoa commented Jun 12, 2024

This PR improves the repository documentation for a better understanding of the eox-audit-model plugin.

For repo description, same as the readme.

Additional information
JIRA

@Alec4r Alec4r requested a review from MaferMazu June 12, 2024 09:40
@dcoa dcoa requested a review from a team June 18, 2024 14:12
Copy link
Contributor

@magajh magajh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dcoa, thank you!

README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Show resolved Hide resolved
README.rst Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved

.. image:: https://img.shields.io/badge/Status-Maintained-brightgreen
- Tracks changes to specified models.
- Logs detailed information about create, update, and delete operations.

Installation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add information in this section about how to install this in Tutor, similar to the explanation here: eox-tenant installation. What do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, I forgot to answer.

I have a question about it because the audit model requires direct modification in the code (add the decorator or the method), should be recommended to be installed by tutor OPENEDX_EXTRA_PIP_REQUIREMENTS, or should be installed through the plugin or code that wants to use it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @magajh. I think it would be valuable to briefly explain how to install it with Tutor.

About your question @dcoa, I think that the way of installation we should recommend is with OPENEDX_EXTRA_PIP_REQUIREMENTS, so when you have that plugin installed, you can use it in your code as you prefer. Also, we already install audit-model using that config, e.g., audit-model in quince.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dcoa, please ping me when you've addressed this comment so I can leave my approval :)

Copy link
Contributor Author

@dcoa dcoa Jul 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MaferMazu @magajh I rewrote the installation instructions to use Tutor.

Thanks for your feedback :)

README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
@dcoa dcoa force-pushed the dcoa/improve-docs branch 3 times, most recently from 744606b to b9d6fba Compare June 26, 2024 11:45
@dcoa dcoa force-pushed the dcoa/improve-docs branch from d7adc8e to d591e86 Compare July 9, 2024 09:35
@github-actions github-actions bot added size/m and removed size/s labels Jul 9, 2024
@MaferMazu
Copy link
Contributor

@dcoa, thanks for this PR. It looks good to me. I only added a comment in the Tutor installation discussion, but that's it.

Please let me know when you have resolved the conversations to retake a look.

@magajh magajh self-requested a review July 15, 2024 14:52
@dcoa dcoa merged commit 23c3a19 into master Jul 15, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants